-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on/off -g does not change the current session #37
Comments
Some small function/conditional cleanup
Yes those are correct expectations and it is very clear how you expect these controls to work now. I cleaned up the code and pull request is in for review; hopefully this will fix this once and for all. Thank you again for explaining this and being patient for a fix, I appreciate all the feedback as it has helped me with this project greatly. |
No problem, I don't see the PR. Feel free to @ me there. |
I guess that's not a PR. :) That's fine. I'll try out. |
Works as I expected now, thanks. |
Clean up kubeon and off to match #37
Starting state:
kubeoff -g
, run 3 shell windowsWhen I run
kubeon -g
on the current shell, I expect:Current behavior:
Starting state:
kubeon -g
, run 3 shell windowsWhen I run
kubeoff -g
on the current shell, I expect:Current behavior:
Are my expectations not accurate? I kind of expected kubeon/kubeoff to work this way.
The text was updated successfully, but these errors were encountered: