Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on/off -g does not change the current session #37

Closed
ahmetb opened this issue Feb 21, 2018 · 5 comments
Closed

on/off -g does not change the current session #37

ahmetb opened this issue Feb 21, 2018 · 5 comments

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Feb 21, 2018

Starting state: kubeoff -g, run 3 shell windows

When I run kubeon -g on the current shell, I expect:

  • current shell will turn on the PS1
  • new shells will also have PS1 turned on
  • already open shells (other tabs) will not change behavior when I hit return

Current behavior:

  • current shell doesn't turn on PS1 (UNEXPECTED)
  • new shells have PS1 turned on
  • already open shells (other tabs) are turning it on (UNEXPECTED)

Starting state: kubeon -g, run 3 shell windows

When I run kubeoff -g on the current shell, I expect:

  • current shell will turn OFF the PS1
  • new shells will also have PS1 turned OFF
  • already open shells (other tabs) will not change behavior when I hit return

Current behavior:

  • current shell doesn't turn off PS1 (UNEXPECTED)
  • new shells have PS1 turned off
  • already open shells (other tabs) are turning it on (UNEXPECTED)

Are my expectations not accurate? I kind of expected kubeon/kubeoff to work this way.

jonmosco added a commit that referenced this issue Feb 23, 2018
Some small function/conditional cleanup
@jonmosco
Copy link
Owner

Yes those are correct expectations and it is very clear how you expect these controls to work now.

I cleaned up the code and pull request is in for review; hopefully this will fix this once and for all.

Thank you again for explaining this and being patient for a fix, I appreciate all the feedback as it has helped me with this project greatly.

@ahmetb
Copy link
Contributor Author

ahmetb commented Feb 23, 2018

No problem, I don't see the PR. Feel free to @ me there.

@jonmosco
Copy link
Owner

550aa60

@ahmetb
Copy link
Contributor Author

ahmetb commented Feb 23, 2018

I guess that's not a PR. :) That's fine. I'll try out.

@ahmetb
Copy link
Contributor Author

ahmetb commented Feb 23, 2018

Works as I expected now, thanks.

@ahmetb ahmetb closed this as completed Feb 23, 2018
jonmosco added a commit that referenced this issue Feb 23, 2018
Clean up kubeon and off to match #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants