Skip to content

Commit

Permalink
Fix Style linting issues (hackforla#2495)
Browse files Browse the repository at this point in the history
* Find all css linting errors

* Fixed about page css linting issues

* Removed duplicate class in _dashboard.scss

* Fixed linting issues in _events.scss

* Fixed linting issues in _home.scss

* Fixed linting issues in _project-page.scss

* Fixed linting issues in _toolkit.scss

* Adding ignore for duplicate properties in stylelintrc

* Fixed accordion css issues

* Changed margin in _events.scss

* Reverted changes to _toolkit.scss
  • Loading branch information
averdin2 authored Dec 15, 2021
1 parent de29138 commit 998b164
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 59 deletions.
2 changes: 1 addition & 1 deletion .stylelintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
"no-duplicate-selectors": true,
"no-extra-semicolons": true
}
}
}
20 changes: 6 additions & 14 deletions _sass/components/_about.scss
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
a.anchor {
display: block;
position: relative;
top: -75x;
top: -75px;
visibility: hidden;
}

Expand Down Expand Up @@ -126,10 +126,9 @@ a.anchor {
overflow: hidden;
border: 0 solid rgba(51, 51, 51, 0.06);
border-radius: 16px;
margin-bottom: 0;
margin: 12px;
padding: 22px;
height: fit-content;
margin: 12px;
}

// Make the Letter page card have square corners
Expand Down Expand Up @@ -253,8 +252,7 @@ a.anchor {
}

.sub-card-content {
padding-left: 5px;
padding-left: 23px;
padding-left: 10px;
margin-left: 8px;
}

Expand Down Expand Up @@ -592,17 +590,11 @@ a.anchor {
} // End below tablet

// Bigger than mobile - 480px
@media #{$bp-mobile-up} {

} // End mobile up
// @media #{$bp-mobile-up} {}
// End mobile up

// Bigger than tablet - 768px
@media #{$bp-tablet-up} {
.wins-card-mobile{
margin-left: auto;
margin-right: auto;
}
}
// @media #{$bp-tablet-up} {}

//Bigger than desktop - 960px
@media #{$bp-desktop-up} {
Expand Down
6 changes: 1 addition & 5 deletions _sass/components/_dashboard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,4 @@

iframe{
margin: 0 auto 0 auto;
}

.dashboardEmbed {
background-color: #020d2d;
}
}
34 changes: 3 additions & 31 deletions _sass/components/_events.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
margin: 40px 0px 83px 0px;
padding: 25px;
@media #{$bp-below-tablet} {
margin-top: 52px;
margin: 0;
padding: 0;
margin: 0px;
}
}

Expand Down Expand Up @@ -273,9 +272,8 @@
box-shadow: 0 0 8px 0 rgba(51, 51, 51, 0.2);
overflow: hidden;
max-width: 996px;
margin-bottom: 0;
padding: 20px;
margin: 45px;
padding: 20px;
font-family: "Roboto" sans-serif;
height: fit-content;

Expand Down Expand Up @@ -347,37 +345,11 @@

.title-meetup {
font-size: 1.25rem;
text-align: center;
font-weight: 700;
text-align: left;
font-weight: 700;
margin-bottom: 16px;


}

// .btn-meet {
// background: #fa114f;
// border: 2;
// border-radius: 60px;
// box-shadow: 0 0 8px 0 rgba(51, 51, 51, 0.2);
// color: #fff;
// display: inline-block;
// font-size: 25px;
// font-weight: 400;
// height: 86px;

// padding: 0 20px;
// text-decoration: none;
// transition: all 100ms ease-in;
// white-space: nowrap;
// width: 62%;

// @media #{$bp-below-mobile} {
// font-size: 1.1rem;
// width: 70%;
// }
// }

.class-btn {
text-align: center;
margin-top: 8px;
Expand Down
1 change: 0 additions & 1 deletion _sass/components/_home.scss
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,6 @@ button {
.column {
display: flex;
flex-direction: column;
flex-basis: 100%;
flex: 1;
}

Expand Down
6 changes: 3 additions & 3 deletions _sass/components/_project-page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
display: flex;
justify-content: center;
flex-direction: column;
text-align: center;
text-align: left;
border: 1px solid rgba(51,51,51,0.1);
border-radius: 16px;
padding: 5px 15px;
Expand All @@ -208,7 +208,7 @@
max-width: 0px;
padding: 35px 0px;
overflow: hidden;
text-align: center;
text-align: left;
min-width: 0px;
transition: min-width 1s, padding 1s;
}
Expand Down Expand Up @@ -348,7 +348,7 @@
max-height: 175px;
max-width: 229px;
margin: 0px 0px 30px 21px;
text-align: center;
text-align: left;
border: 1px solid rgba(51,51,51,0.1);
border-radius: 16px;
padding: 5px 15px;
Expand Down
5 changes: 1 addition & 4 deletions _sass/elements/_accordion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
border-bottom: 0.5px solid gray;
max-width: 1000px;
margin-top: 45px;
padding: 0.2rem;

@media #{$bp-below-mobile} {
margin-top: 20px;
Expand Down Expand Up @@ -34,10 +35,6 @@
font-size: 24px;
}

.accordion {
padding: 0.2rem;

}

.active::after {
content: "\221F";
Expand Down

0 comments on commit 998b164

Please sign in to comment.