Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate chunked-request #22

Open
jonnyreeves opened this issue Sep 21, 2016 · 1 comment
Open

Deprecate chunked-request #22

jonnyreeves opened this issue Sep 21, 2016 · 1 comment

Comments

@jonnyreeves
Copy link
Owner

Appreciate that this library doesn't have many users; however as mentioned in #20, I've taken a very different approach and pulled the guts of this library out into a new package: https://github.com/jonnyreeves/fetch-readablestream/

fetch-readablestream focuses on providing cross-browser support for streaming a response using something resembling the fetch API (note: it does not implement all the methods of fetch - it's specifically just for those of us who need to stream binary data).

Factoring this logic out doesn't leave much for chunked-request to do - infact the current default chunk parser can be re-implemented in a few lines of user code, eg: https://github.com/jonnyreeves/fetch-readablestream/blob/release/v0.1.0/test/integ/util.js -- personally I am tempted to just deprecate this library and eventually remove the library from npm - but I am happy to port it / maintain it if others get use out of the API it exposes.

Thanks for your contributions @MarcusLongmuir @Ruben-Hartog @ariutta and @jimmywarting

@ariutta
Copy link
Contributor

ariutta commented Sep 23, 2016

I think you're on the right track. Just be aware that NPM doesn't generally
allow deleting packages anymore -- you can only deprecate.

On Sep 21, 2016 8:42 AM, "John Reeves" notifications@github.com wrote:

Appreciate that this library doesn't have many users; however as mentioned
in #20 #20, I've
taken a very different approach and pulled the guts of this library out
into a new package: https://github.com/jonnyreeves/fetch-readablestream/

fetch-readablestream focuses on providing cross-browser support for
streaming a response using something resembling the fetch API (note: it
does not implement all the methods of fetch - it's specifically just for
those of us who need to stream binary data).

Factoring this logic out doesn't leave much for chunked-request to do -
infact the current default chunk parser can be re-implemented in a few
lines of user code, eg: https://github.com/jonnyreeves/fetch-
readablestream/blob/release/v0.1.0/test/integ/util.js -- personally I am
tempted to just deprecate this library and eventually remove the library
from npm - but I am happy to port it / maintain it if others get use out of
the API it exposes.

Thanks for your contributions @MarcusLongmuir
https://github.com/MarcusLongmuir @Ruben-Hartog
https://github.com/Ruben-Hartog @ariutta https://github.com/ariutta
and @jimmywarting https://github.com/jimmywarting


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#22, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABPJg4TNgqzWY7JznppSNarpzRdgV35Iks5qsVBPgaJpZM4KC9jm
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants