Multifetch Adapter #3
Conversation
There was a problem hiding this comment.
Hi! Thanks for the pull request. It looks great however, I think the name of the adapter should be changed to indicate it only deals with sending GET requests; something like 'HttpGetMultiFetchAdapter'. Also a test verifying the de-serialization of the adapter would be good. This would be beneficial for someone reading code to figure out what the response structure should be. Also maybe add a quick explanation of the adapter and what server version it works with to help others understand if they can use it (as a class level comment). Once again many many thanks for the pull request!
|
Have done the rename and explanation. I have deferred the test until you have done one in your adapter - much easier to copy yours (you can see how incompetent I am by the accidental submission of this PR when I was just trying to submit a one line PR to sort out the build process). |
No description provided.