Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think pos == nulll logic is not rigorous enough #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jweboy
Copy link

@jweboy jweboy commented Apr 5, 2018

In the pos == null decision, I think the better way is to use === instead of ==. Second, the value of pos may also be undefined. When ==, null == undefined is true, but=== is more rigorous, because null and undefined are two different values themselves, so === can be judged as two Different values, so I mentioned such a modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant