Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heads up: broken in node v19.1 #30

Closed
ljharb opened this issue Nov 19, 2022 · 1 comment
Closed

heads up: broken in node v19.1 #30

ljharb opened this issue Nov 19, 2022 · 1 comment

Comments

@ljharb
Copy link
Collaborator

ljharb commented Nov 19, 2022

I filed this as nodejs/node#45514, so hopefully node will fix it, but I wanted you to be aware of it in case they don't, or in case node v20 will end up with the same breaking url.parse changes.

@Trott
Copy link

Trott commented Nov 22, 2022

Should be fixed in the next release of Node.js 19 (hopefully next week). Things might change, but at this moment, my expectation is that there will be a runtime warning in Node.js 20 (release scheduled for April 2023) and then the breaking change will be introduced in Node.js 21 (release scheduled for October 2023).

ljharb added a commit that referenced this issue Jun 26, 2024
ljharb added a commit that referenced this issue Jun 26, 2024
@ljharb ljharb closed this as completed in 37881a3 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants