Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 and JSX support #104

Closed
osenvosem opened this issue Oct 12, 2015 · 5 comments
Closed

ES6 and JSX support #104

osenvosem opened this issue Oct 12, 2015 · 5 comments

Comments

@osenvosem
Copy link

Please add ES6 and JSX support.
Now it looks like:
screen shot 2015-10-12 at 10 10 04
And this is Babel highlighting:
screen shot 2015-10-12 at 10 10 12

@jonschlinkert
Copy link
Owner

sure, I can add this next time I have a chance to make edits. or would you like to do a pr?

@osenvosem
Copy link
Author

@jonschlinkert I would like to with pleasure, if I had enough skills for that.
Btw, I asked you to add twig support on the 12th of May. Today is the 12th of October. Such a coincidence.

@tomchentw
Copy link
Contributor

@jonschlinkert I'd love to help out this since currently the color just breaks for JSX elements, making it very ugly and weird.

For what I can tell, I should modify some places from these code block sections:
https://github.com/jonschlinkert/sublime-markdown-extended/blob/master/Syntaxes/Markdown%20Extended.sublime-syntax#L265-L279

and to change syntax highlighter to use babel. Am I correct?

@nathanmarks
Copy link

@tomchentw did you fork this with any luck?

@jonschlinkert
Copy link
Owner

I should have closed this before. the "strange coloring" is from changes in ST3, some of which seem unfixable at this level.

@tomchentw @nathanmarks fork the hell out of it. this is open source, I do this in my spare time. I'm glad people get value of the package, but every time someone makes a comment like that it makes me want to make all of my repos private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants