Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST3 Build 3103 #62

Open
jonschlinkert opened this issue Feb 10, 2016 · 7 comments
Open

ST3 Build 3103 #62

jonschlinkert opened this issue Feb 10, 2016 · 7 comments

Comments

@jonschlinkert
Copy link
Owner

jonschlinkert commented Feb 10, 2016

Edited (October 7, 2018): I just pushed up some changes, please see #88. Let me know if this works for you, I would appreciate any feedback.


If you update to ST Build 3013, you might notice that your colors are different. This is due to changes in ST, nothing was changed in this theme.

I personally find the colors way too busy now, so I'll be making some improvements. In the meantime, if you have any feedback or preferences, please comment here. Thanks!

@tunnckoCore
Copy link

You may mean 3103 build? lol, no problems :D 👍
And yes, i noticed the changes earlier today, firstly not like them, but now i find logic in some of them. It's cool to color every method name when params given to it, and not color method name and color parenthesis when no params to it. Or.. i just not noticed it to now, lol.

screenshot from 2016-02-11 00-53-01

But yea, I dont like that object properties are same color as strings.

And now, currently I dont use your theme, but the things are same everywhere :)

Btw, hot discussion was opened sublimehq/Packages#141

Cheers,
Charlike.

@jonschlinkert
Copy link
Owner Author

I was able to easily fix most of the color changes. Also, since it's super easy to create new themes, and to toggle to different themes, I might just add a few different choices so that uses can have what they want.

@orbitbot
Copy link

Old New
sublime-text-old-monokai sublime-text-new-monokai

These screenshots highlight the main problems I'm having right now:

  • dots are red instead of white, which makes them difficult to see
  • object keys are highlighted the same way as strings even when not defined as such (eg. 'someString') which is confusing (even if in practice actually true for js)
  • the : after object keys is colored purple, which makes it difficult to see

@tunnckoCore
Copy link

@orbitbot it's because the new engine of sublime and won't be changed as i remember (but Jon can provide way to configure it?). see more sublimehq/Packages#141

Actually, initially, i also don't like it, but now it seems better and okey to me.

@jonschlinkert
Copy link
Owner Author

I have fixes for a lot of these issues. I'll try to push up today

@karolyi
Copy link

karolyi commented Jun 12, 2016

+1, subscribing here to see when #69 gets fixed.

@jonschlinkert
Copy link
Owner Author

Please see #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants