revert: Surprising param encoding #900

jooby-project · Oct 22, 2017 · c7e8636 · c7e8636
1 parent 3e9bd1b
commit c7e8636
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/jooby/src/main/java/org/jooby/Router.java b/jooby/src/main/java/org/jooby/Router.java
@@ -230,13 +230,12 @@
 public interface Router {
 
   /**
-   * Decode a path by delegating to {@link URLDecoder#decode(String, String)}. This function keeps
-   * the <code>+</code> character.
+   * Decode a path by delegating to {@link URLDecoder#decode(String, String)}.
    *
    * @param path Path to decoded.
    */
   static String decode(String path) {
-    return Try.apply(() -> URLDecoder.decode(path.replace("+", "%2b"), "UTF-8")).get();
+    return Try.apply(() -> URLDecoder.decode(path, "UTF-8")).get();
   }
 
   /**

diff --git a/modules/coverage-report/src/test/java/org/jooby/PathVarMustBeDecodedFeature.java b/modules/coverage-report/src/test/java/org/jooby/PathVarMustBeDecodedFeature.java
@@ -17,6 +17,6 @@ public void pathVarShouldBeDecoded() throws Exception {
 
     request()
         .get("/plus+plus")
-        .expect("plus+plus");
+        .expect("plus plus");
   }
 }
diff --git a/modules/coverage-report/src/test/java/org/jooby/issues/Issue900.java b/modules/coverage-report/src/test/java/org/jooby/issues/Issue900.java
@@ -18,7 +18,7 @@ public void shouldNotEncodingPlusSign() throws Exception {
     int ch = '+';
     System.out.println(Integer.toHexString(ch));
     request().get("/900/a+b")
-        .expect("a+b");
+        .expect("a b");
   }
 
 }