Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove force recompilation of classes from jooby:spec #800

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

ajcamilo
Copy link
Contributor

I was having issues with my build cycle and the main reason was because jooby:spec forks the compilation to generate the spec file and after this the default compilation occurs.

jooby:spec executes the build to the process-classes phase.

Besides my compilation problems (mainly because of ebean and querybean enhacement), another down side of this is that the compilation is much slower (2 compilations).

This PR just removes the execution of the process-classes and if the plugin is set to execute in the phase process-classes everything works as expected.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.886% when pulling 40070d5 on ajcamilo:master into 209a7ac on jooby-project:master.

@jknack jknack added this to the 1.2.0 milestone May 27, 2017
@jknack
Copy link
Member

jknack commented Jun 2, 2017

I changed the project structure and your pull can't be merge it, sorry for that.

But don't worry going to pick your commit and merge them my self later (unless you want to do it :)

@ajcamilo
Copy link
Contributor Author

ajcamilo commented Jun 2, 2017

rebase done 😉

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.886% when pulling 9d1ad58 on ajcamilo:master into 8ae900f on jooby-project:master.

@jknack
Copy link
Member

jknack commented Jun 2, 2017

Merged it. Much appreciated!

@jknack jknack merged commit 9985a02 into jooby-project:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants