Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor #90

Merged
merged 5 commits into from
Jun 5, 2018
Merged

Minor #90

merged 5 commits into from
Jun 5, 2018

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 5, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jun 5, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 92.244% when pulling dcd5c5f on jsoref:minor into fbd5c65 on joohoi:master.

joohoi
joohoi approved these changes Jun 5, 2018
View reviewed changes
Copy link
Owner

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@joohoi joohoi merged commit 0bbbf5e into joohoi:master Jun 5, 2018
@jsoref jsoref deleted the minor branch June 5, 2018 09:53
jacobmyers-codeninja pushed a commit to jacobmyers-codeninja/acme-dns that referenced this pull request Sep 30, 2020
@jsoref
Minor (joohoi#90)
b62d538 
* add periods to sentences

* markdown

* reword

* reword: the item _acme-challenge should be a cname, not a cname to _acme-challenge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joohoi joohoi joohoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @coveralls @joohoi