Skip to content

Commit

Permalink
Do not count tests as failed that have not started
Browse files Browse the repository at this point in the history
Before this commit, when the user interrupted a test run, tests that had not started until that point were counted as failed, whereas tests that were already running were counted as skipped.

With this commmit, both types of tests are counted as skipped.

Closes bazelbuild#17160.

PiperOrigin-RevId: 501495265
Change-Id: I4dd157c32d70eb46a02070251684899b84c9802e
  • Loading branch information
fmeum authored and copybara-github committed Jan 12, 2023
1 parent f0ed5ca commit 16427c9
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ public void notify(Set<TestSummary> summaries, int numberOfExecutedTargets) {
for (TestSummary summary : summaries) {
if (TestResult.isBlazeTestStatusPassed(summary.getStatus())) {
stats.passCount++;
} else if (summary.getStatus() == BlazeTestStatus.NO_STATUS) {
} else if (summary.getStatus() == BlazeTestStatus.NO_STATUS
|| summary.getStatus() == BlazeTestStatus.BLAZE_HALTED_BEFORE_TESTING) {
stats.noStatusCount++;
} else if (summary.getStatus() == BlazeTestStatus.FAILED_TO_BUILD) {
stats.failedToBuildCount++;
Expand Down

0 comments on commit 16427c9

Please sign in to comment.