Cleanup and Performance #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no need to check if there is a closing curly brace. json_decode will later cause an exception if there is a problem with JSON. Also ini files (strings) do not have curly braces at start/end
…in a loop - type safe comparisons - removal of unnecessary parentheses - double quotes to single quotes - replace is_null() - flip conditions where the latter was cheaper - formatting
- formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
replace substr with array access
no need to check if there is a closing curly brace. json_decode will later cause an exception if there is a problem with JSON. Also ini files (strings) do not have curly braces at start/end
extracted an array accessed variable that was looped unnecessarily in a loop
type safe comparisons
removal of unnecessary parentheses
double quotes to single quotes
replace is_null()
flip conditions where the latter was cheaper
formatting
[tests]
Testing Instructions
Code review?