Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test consolidation #37

Open
wants to merge 10 commits into
base: 2.0-dev
Choose a base branch
from
Open

Test consolidation #37

wants to merge 10 commits into from

Conversation

nibra
Copy link
Contributor

@nibra nibra commented Sep 21, 2021

Reorganisation and completion of tests

This package still uses phputf8, which has long been abandoned.
In preparation of an exchange (see #29), this PR increases the test coverage from ~75% to >96%.
A few small issues have necessarily been solved on the way.

Summary of Changes

Tests

  • Add test cases
  • Improve testdox annotations
  • Add type hints

StringHelper

  • Reduce complexity to increase path/branch coverage

Inflector

  • Remove internal use of deprecated code

phputf8

  • Fix bug in str_ireplace() - count variable was not populated

Testing Instructions

  • Code Review. Make sure that signatures in StringHelper and Inflector did not change in an incompatible way. Changes to signatures should only affect default values.

Documentation Changes Required

None.

@nibra nibra mentioned this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant