Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skip tour to cancel the tour and not see it again #27

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

obuisard
Copy link
Contributor

The tours have now an auto-start functionality.
Cancelling a tour will not hide it forever. The tour will run again 10mn later.
We need to add 'skip' to not run the tour again.

@laoneo
Copy link
Contributor

laoneo commented Jul 22, 2024

Can we not replace the cancel function with the skip code, as this is what is expected. If I cancel tours, it should never appear again.

@obuisard
Copy link
Contributor Author

Can we not replace the cancel function with the skip code, as this is what is expected. If I cancel tours, it should never appear again.

I left it so that when this is merged, we don't break testing until the auto-start functionality is accepted for guided tours.

@laoneo laoneo merged commit 00db028 into joomla-projects:main Jul 22, 2024
@laoneo
Copy link
Contributor

laoneo commented Jul 22, 2024

Thanks!

@muhme
Copy link
Contributor

muhme commented Jul 22, 2024

@obuisard I would also vote in favour of replacing in the existing command. Having skipTour() and cancelTour() permanently sounds unfavourable to me. Can't we implement that the testing don't break before and after the auto-start functionality is accepted for guided tours? I can help with implementation and testing.

@laoneo
Copy link
Contributor

laoneo commented Jul 22, 2024

Sure, go ahead with a proposal

muhme added a commit to muhme/joomla-cypress that referenced this pull request Jul 27, 2024
muhme added a commit to muhme/joomla-cypress that referenced this pull request Jul 27, 2024
muhme added a commit to muhme/joomla-cypress that referenced this pull request Jul 27, 2024
@muhme muhme mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants