Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library extension for enhanced batched tag handling #242

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

beni71
Copy link

@beni71 beni71 commented Mar 23, 2024

User description

Library extension for enhanced batched tag handling from joomla/joomla-cms#40613


PR Type

documentation, enhancement


Description

  • Added documentation for new deprecations related to tag handling functions in Joomla! 7.0.
  • Deprecated postStoreProcess function in TagsHelper and provided a replacement postStore.
  • Deprecated batchTag function in AdminModel and introduced a new batchTags function.
  • Documented a new feature allowing batch removal of tags.

Changes walkthrough 📝

Relevant files
Documentation
new-deprecations.md
Document deprecations and replacements for tag handling functions

migrations/54-60/new-deprecations.md

  • Added information about class deprecations planned for Joomla! 7.0.
  • Documented deprecation of postStoreProcess in TagsHelper.
  • Documented deprecation of batchTag in AdminModel.
  • Provided replacements for deprecated functions.
  • +17/-0   
    new-features.md
    Document new feature for batched tag removal                         

    migrations/54-60/new-features.md

  • Added a new feature section for batched tag enhancement.
  • Documented the ability to batch remove a tag.
  • +3/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @beni71 beni71 changed the title Added library extension docu for enhanced batched tag handling (#40613) Library extension for enhanced batched tag handling Mar 23, 2024
    @beni71 beni71 marked this pull request as draft March 24, 2024 12:41
    @HLeithner
    Copy link
    Member

    Needs update after reference pr

    @laoneo laoneo added the 6.0 PR for Joomla 6.0 label Mar 27, 2024
    @beni71 beni71 closed this Nov 17, 2024
    @beni71 beni71 deleted the patch-1 branch November 17, 2024 21:28
    @beni71 beni71 restored the patch-1 branch November 17, 2024 21:33
    @beni71 beni71 reopened this Nov 17, 2024
    @beni71 beni71 marked this pull request as ready for review November 17, 2024 22:25
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Clarity
    The documentation should clarify whether the new postStore() function maintains backward compatibility with the old postStoreProcess() function's parameters and return values

    Documentation Completeness
    The documentation should include migration examples showing how to update code from using deprecated functions to using the new functions

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants