Skip to content
This repository has been archived by the owner on Jan 25, 2021. It is now read-only.

[RFC Add weights to fonts schemes names #262

Closed

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Nov 30, 2020

Pull Request for Issue # .

Summary of Changes

Shall we do that?

Testing Instructions

Apply the changes of this PR.

Actual result BEFORE applying this Pull Request

2020-11-28_17

Expected result AFTER applying this Pull Request

2020-11-30_fonts-schemes-idea-3

Documentation Changes Required

None.

@brianteeman
Copy link
Contributor

Only if you explain when its 700 and when its 400

eg Fira Sans (headings 700 body 400)

or something like that

@richard67
Copy link
Member Author

@brianteeman Then we might need to make it translatable strings. Or can we still hard-code it like now?

@richard67
Copy link
Member Author

Right now, always headings comes first in the name, then body.

@brianteeman
Copy link
Contributor

it all depends if you want users to be mind readers and good at guessing or not. Especially if you dont know any css then the numbers are meaningless

@richard67
Copy link
Member Author

@brianteeman How about this?

2020-11-30_fonts-schemes-idea-2

A bit long, but I'd like to keep the "local" and "web" somewhere so people can see where their fonts come from without having to open the dropdown.

And do you think we should make it translatable? The more we add, the more it might be weird with RTL.

@richard67
Copy link
Member Author

Or maybe better:

2020-11-30_fonts-schemes-idea-3

@brianteeman
Copy link
Contributor

brianteeman commented Nov 30, 2020

, but I'd like to keep the "local" and "web"

I wondered why you had that. I see your logic but not sure I see the need

do you think we should make it translatable?

Probably - but obviously not the font name

@richard67
Copy link
Member Author

Probably - but obviously not the font name

@brianteeman Then we can only make a comment in the language file not to translate these words in the string, or we have to create an own custom field where we use an sprintf. For not I think we leave it hard-coded.

@richard67 richard67 changed the title Add weights to fonts schemes names [RFC Add weights to fonts schemes names Nov 30, 2020
@richard67
Copy link
Member Author

Closing as the work in this repository here has been finished, and the result has been merged with joomla/joomla-cms#31520 in the CMS repository.

If necessary we can come back to what's done in this PR here with a PR in the CMS repository.

@richard67 richard67 closed this Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants