Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User form field type; user not selected if search is performed in pop-up. #13306

Closed
cjcliffe opened this issue Dec 20, 2016 · 15 comments
Closed

Comments

@cjcliffe
Copy link

cjcliffe commented Dec 20, 2016

Steps to reproduce the issue

  1. Open an administrator form that has a User form field on it (i.e. User Notes)
  2. Type a user name or keyword into the search box and submit
  3. Click one of the resulting users; the dialog is dismissed

Expected result

The user selected in the pop-up should populate the user form field.

Actual result

Nothing happens; the form field is left empty and it's necessary to click again (without searching) and select the user.

System information (as much as possible)

Does not appear browser or system dependent; is happening on multiple development and live systems running with various configurations on the latest Joomla release.

Additional comments

Is a minor annoyance among our customers but would be nice to get resolved; opening the dialog a second time at least keeps the previous search filter.

@ghost
Copy link

ghost commented Feb 1, 2017

Searching a User in "user Notes" got a list of Notes for User. Maybe i don't understand your issue, can you please explain?

Test on:

Joomla! 3.7.0-staging
macOS Sierra, 10.12.3
Firefox 50.1.0
PHP 7.0.4
MySQLi 5.5.53-0

@angeltoribio-UPC-BCN
Copy link
Contributor

I've discovered the same problem.

  1. Go to Admin, create a new contact (/index.php?option=com_contact&view=contact&layout=edit)
  2. click on linked user and a modal dialog appears
  3. use the search box to find any user
  4. click on any of the users of the obtained list
  5. the modal dialog closes and the linked user continues empty
  6. click again and now select (no text search) any of the listed users
  7. linked user appears now in the field.

Every time you perform a search the first user selection is ignored.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13306.

@ghost
Copy link

ghost commented Feb 4, 2017

@atgbcn cannot confirm Issue: Tested like written Steps 1 to 5: Modal Dialog closes and User is set in Linked user.

Test on:

Joomla! 3.7.0-beta1
macOS Sierra, 10.12.3
Firefox 50.1.0
PHP 7.0.4
MySQLi 5.5.53-0

@angeltoribio-UPC-BCN
Copy link
Contributor

angeltoribio-UPC-BCN commented Feb 4, 2017

@franz-wohlkoenig my test was done using windows-10 and chrome at my job's computer.

At home I'm testing using

Joomla! 3.6.5 Stable [ Noether ] 1-December-2016 22:46 GMT
macOS Sierra, 10.12.2
Google Chrome 55.0.2883.95 (64-bit)
PHP 5.6.21
MySQL 5.5.52-cll

and the same problem appears.

I've also tested the issue using
Firefox 51.0.1 (64-bit)
macOS Sierra, 10.12.2

and it behaves correctly.

I remember testing the issue on windows using Google Chrome and Firefox and the problem appeared too.

I'll send you the exact versions of the windows browsers on Monday.

Thanks!

@ghost
Copy link

ghost commented Feb 4, 2017

Test on:

Joomla! 3.7.0-beta1
Windows Server 2008 (remote)
Firefox 47.0.2
Internet Explorer 11
PHP 7.0.4
MySQLi 5.5.53-0


Works: Modal Dialog closed, User set in Linked user.

@angeltoribio-UPC-BCN
Copy link
Contributor

@franz-wohlkoenig maybe Joomla! 3.7.0-beta1 has that issue fixed. I'm running the last stable version Joomla! 3.6.5 Stable [ Noether ] 1-December-2016 22:46 GMT

Anyway, I'll send you the windows browser's specs on Monday.

Thanks!

@angeltoribio-UPC-BCN
Copy link
Contributor

Good morning @franz-wohlkoenig

I'm running Windows 10.0.10586 at my office.

I've updated my browsers but I still can reproduce the issue using

Google Chrome 56.0.2924.87 (64-bit)
IE 11.713.10586.0

This browser works as expected
Firefox 51.0.1 (64-bit)

Thanks!

@ghost
Copy link

ghost commented Feb 6, 2017

@atgbcn there are more Issues depending on OS and/or Browser > seems this too. Similaer #13594

@alagesanbe08
Copy link

hi i have same issue in Google chrome, i find solution for this.

This issue occur because of mootools check.

"index.php?option=com_users&view=users&layout=modal&tmpl=component&required=0&field={field-user-id}&ismoo=0&excluded=WyIiXQ=="

this is request url for user model popup.

input parameter ismoo = 0
administrator/components/com_users/views/users/tmpl/modal.php:
Line No: 39
$isMoo = $input->getInt('ismoo', 1);//default value of ismoo=1

when search user, form will submit but form search it did't pass ismoo variable so it take default variable ismoo=1.

so solution is

administrator/components/com_users/views/users/tmpl/modal.php:
add following line to form

That it , now its working in Google chrome.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13306.

@alagesanbe08
Copy link

<input type="hidden" name="ismoo" value="" />
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13306.

@alagesanbe08
Copy link

hi, i don't know, how to display php code in value. just echo $isMoo; in value field. sorry for 3 reply.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13306.

@ghost
Copy link

ghost commented Feb 13, 2017

@zero-24 can you have a look on this?

@joomdonation
Copy link
Contributor

joomdonation commented Feb 13, 2017

@alagesanbe08 Thanks, nice find. I had the issue on Joomla 3.6.5 with my custom extensions, applied the fix and the issue is sorted

Your proposed fix has included in stagging, so it will be fixed in 3.7.0, see https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/views/users/tmpl/modal.php#L126

(The code is a bit ugly, it should just be echo $isMoo instead of calling $input->get again)

@ghost
Copy link

ghost commented Feb 13, 2017

@cjcliffe @atgbcn can you test 3.7 like @joomdonation wrote?

@zero-24
Copy link
Contributor

zero-24 commented Feb 13, 2017

@joomdonation I agree with you here is the PR: #14047 that should fix that problem 😄

@zero-24 zero-24 closed this as completed Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants