Use $ismoo instend of calling jinput

[zero-24]

Pull Request for Issue #13306

Summary of Changes

• Use $ismoo instend of calling jinput
• a bit CS

Testing Instructions

1. Open an administrator form that has a User form field on it (i.e. User Notes)
2. Type a user name or keyword into the search box and submit
3. Click one of the resulting users; the dialog is dismissed

Expected result

The user selected in the pop-up should populate the user form field.

Actual result

In 3.6.5 it is broken as the $ismoo value is missing.
In 3.7-dev it is working but don't uses the $ismoo it gets the value from the jinput object

Documentation Changes Required

None

[joomdonation]

I have tested this item ✅ successfully on abccdaf

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14047.}

[joomdonation]

Since you made this change, could you please this line https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/views/users/tmpl/modal.php#L23 to

$input = JFactory::getApplication()->input;

and remove the line above https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/views/users/tmpl/modal.php#L22

(The $app variable is used one time only, thus it should be removed)

[zero-24]

Done thanks @joomdonation

[joomdonation]

I have tested this item ✅ successfully on 29dab64

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14047.}

[dgrammatiko]

I have tested this item ✅ successfully on 29dab64

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14047.}

[dgrammatiko]

RTC