Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Outdated dependency - chosen-js #28154

Closed
C-Lodder opened this issue Feb 29, 2020 · 9 comments
Closed

[4.0] Outdated dependency - chosen-js #28154

C-Lodder opened this issue Feb 29, 2020 · 9 comments

Comments

@C-Lodder
Copy link
Member

Expected version: 1.8.7
Actual version: 1.6.2

@C-Lodder C-Lodder changed the title [4.0] Oudated dependency - chosen-js [4.0] Outdated dependency - chosen-js Feb 29, 2020
@brianteeman
Copy link
Contributor

This one is intentional

@C-Lodder
Copy link
Member Author

Why would it be intentional?

@brianteeman
Copy link
Contributor

Because they broke BC iirc

@wilsonge
Copy link
Contributor

wilsonge commented Mar 1, 2020

We can probably try and figure out an upgrade path - given chosen itself looks like it's about to die harvesthq/chosen@91041bc

@C-Lodder
Copy link
Member Author

C-Lodder commented Mar 1, 2020

I thought Chosen was replaced with Choices/Awesomplete?
Is is still being used in certain places?

@wilsonge
Copy link
Contributor

wilsonge commented Mar 1, 2020

As far as I know it's not used anymore in core. But it never got removed after choices got added - and as the api's in php for the two methods are fairly different - It's probably one of those things that will stay there forever for the upgrade path but as deprecated method

EDIT: Did a quick search and there's one place left in com_privacy in the frontend (looks like an oversight rather than intentional) - plus an unused-in-core deprecated tags field method.

@Fedik
Copy link
Member

Fedik commented Mar 1, 2020

hm maybe we can find a way to drop it somehow? not really much fun to keep this legacy for long,
it would be known b.c. break

@wilsonge
Copy link
Contributor

#28247 Chosen got dropped from the view as expected

@wilsonge
Copy link
Contributor

PR #28354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants