Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Update chosen to latest version #28354

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

wilsonge
Copy link
Contributor

Pull Request for Issue #28154 .

Summary of Changes

Update chosen to the latest version

Testing Instructions

Add HTMLHelper::_('formbehavior.chosen', 'select'); (I did administrator/components/com_content/tmpl/article/edit.php and check select boxes show as chosen (note some might conflict with either the fancy box or choices views - that's fine - just check regular select boxes)

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 15, 2020
@wilsonge wilsonge changed the title Update chosen to latest version [4.0] Update chosen to latest version Mar 15, 2020
@SharkyKZ
Copy link
Contributor

I have tested this item ✅ successfully on 3078ed4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28354.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 17, 2020

I have tested this item ✅ successfully on 3078ed4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28354.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 17, 2020
@Quy
Copy link
Contributor

Quy commented Mar 17, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28354.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 17, 2020
@wilsonge wilsonge merged commit fb6ba86 into joomla:4.0-dev Mar 17, 2020
@wilsonge
Copy link
Contributor Author

Thanks guys!

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Mar 17, 2020
@wilsonge wilsonge deleted the fix/update-chosen branch March 17, 2020 16:42
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants