Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J4.0 Debug plugin: Debug bar doesn't display logs and deprecated tabs by default, while setting's default is ON #35454

Closed
beat opened this issue Aug 31, 2021 · 2 comments

Comments

@beat
Copy link
Contributor

beat commented Aug 31, 2021

The Debug system plugin's setting Logging tab / Logging fieldset / "Log Entries" (PLG_DEBUG_FIELD_LOGS_LABEL, param logs) has a different default value of 1/true/ON in the settings, but false/0/OFF in the code.

Result is that as long as the DEBUG plugin settings have not been saved, the logs/deprecation tab of the debug bad are not displayed.

XML file default setting: https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/debug/debug.xml#L227
PHP file default setting: https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/debug/debug.php#L179

Steps to reproduce the issue

  • Fresh Joomla install
  • Turn debugging and logging on in global configuration
  • Open the debug bar by clicking the joomla logo at top bottom

Expected result

See "Log", "Deprecated" and "Deprecation notices" tabs on the right of "J! Info Request Session Profile Queries" tabs.

Actual result

Seeing only "J! Info Request Session Profile Queries" tabs.

Then when just saving the Joomla plugin Debug settings WITHOUT changing them, those See "Log", "Deprecated" and "Deprecation notices" tabs suddenly display on the right of "J! Info Request Session Profile Queries" as expected.

System information (as much as possible)

Vanilla Joomla 4.0.2, on any platform.

beat added a commit to beat/joomla-cms that referenced this issue Aug 31, 2021
Fixes bug joomla#35454 (Debug plugin: Debug bar doesn't display logs and deprecated tabs by default, while setting's default is ON)
@beat
Copy link
Contributor Author

beat commented Aug 31, 2021

Proposing PR #35455 to fix this bug.

@alikon
Copy link
Contributor

alikon commented Aug 31, 2021

closing as we have a pr #35455

@alikon alikon closed this as completed Aug 31, 2021
wilsonge pushed a commit that referenced this issue Sep 18, 2021
Fixes bug #35454 (Debug plugin: Debug bar doesn't display logs and deprecated tabs by default, while setting's default is ON)
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this issue Oct 3, 2021
…5455)

Fixes bug joomla#35454 (Debug plugin: Debug bar doesn't display logs and deprecated tabs by default, while setting's default is ON)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants