Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created SCSS folder in Cassiopeia can not be compiled with external compiler #37011

Closed
RickR2H opened this issue Feb 12, 2022 · 6 comments
Closed

Comments

@RickR2H
Copy link
Member

RickR2H commented Feb 12, 2022

Steps to reproduce the issue

  1. Install Joomla 4.1 using the nightly build version
  2. Go to the created folder media\templates\site\cassiopeia\scss and try to build the CSS with NPM or VScode.
  3. The build will fail because of wrong source paths in some of the SCSS files

Looks like the same problems with the Atum template in PR: #36879

Solution is to change the paths to the vendor and system folders in the scss/template.scss, scss/tools/_tools.scss and scss/offline.scss

The build script needs to be changed to handle the updates paths.

@DGT41 could you take a look?

@dgrammatiko
Copy link
Contributor

there's a pr: #36879

@dgrammatiko
Copy link
Contributor

Looks like the same problems with the Atum template in PR: #36879

Did you try it? Did you run npm install after applying that PR?

@RickR2H
Copy link
Member Author

RickR2H commented Feb 13, 2022

The PR works! But that is only for compiling SCSS in a development environment when the build folder is present. I'm talking about a live site with the build media folder. So, download and install a regular Joomla 4.1 installation. Then try to compile the SCSS files in media/templates/site/cassiopeia with a tool of your choice. then you get:

{
"status": 1,
"file": "E:/wamp64/www/j41development/media/templates/site/cassiopeia/scss/tools/_tools.scss",
"line": 2,
"column": 1,
"message": "File to import not found or unreadable: ../../../../vendor/bootstrap/scss/functions.",
"formatted": "Error: File to import not found or unreadable: ../../../../vendor/bootstrap/scss/functions.\n on line 2 of scss/tools/_tools.scss\n from line 5 of scss/template.scss\n>> @import "../../../../vendor/bootstrap/scss/functions";\r\n ^\n"
}

The paths need to be one level up. From: ../../../../../media/vendor/bootstrap/scss/functions to ../../../../media/vendor/bootstrap/scss/functions. Then compiling works.

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Feb 13, 2022

The PR works! But that is only for compiling SCSS in a development environment when the build folder is present.

The pr is not merged for 4.1 so 4.1 will be broken.

@RickR2H
Copy link
Member Author

RickR2H commented Feb 16, 2022

Thanks @dgrammatiko 😉

@RickR2H RickR2H closed this as completed Feb 16, 2022
@RickR2H
Copy link
Member Author

RickR2H commented Feb 16, 2022

Duplicate of #36872


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants