-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Core templates SCSS does not compile in release #36872
Comments
How are you trying to compile it? |
I've tried it with the code from #35403. |
@dgrammatiko Could you have a look on this issue? Thanks in advance. |
The |
However we aren't talking about the PHP compiler, but about the SCSS we are going to ship with 4.1 and that SCSS right now is broken. You can not create an SCSS file which includes that template.scss and run npm to compile it. So please stay on topic. |
If those files aren't meant to be compiled, then delete them now and don't deliver them with our release package. |
You can, the source files are in the build folder... |
Yes probably should be removed |
That folder is not distributed
Irrespective of the phpcss thing having the scss for the templates is useful - assuming that the paths are fixed and they can be used. @Hackwar raises a valid issue here |
What I'm trying to say is JUST KILL SCSS It was a mistake |
Maybe so but for at least the next 6 months we will be shipping it - so it should be usable |
Ok will try to do a pr this weekend |
This can be closed |
Closing as having a pull request. Please test #36879 . Thanks in advance. |
Try to compile the SCSS of the frontend template for example in media/templates/site/cassiopeia/scss/template.scss That is what we are shipping to our users with 4.1 and it does not compile, since it is a copy from the /build folder to the /media folder. However in the /build folder it is another level deeper than in the /media folder and thus for example the above file tries to include files by traveling one level to high in the filesystem.
The text was updated successfully, but these errors were encountered: