Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Core templates SCSS does not compile in release #36872

Closed
Hackwar opened this issue Jan 27, 2022 · 15 comments
Closed

[4.1] Core templates SCSS does not compile in release #36872

Hackwar opened this issue Jan 27, 2022 · 15 comments

Comments

@Hackwar
Copy link
Member

Hackwar commented Jan 27, 2022

Try to compile the SCSS of the frontend template for example in media/templates/site/cassiopeia/scss/template.scss That is what we are shipping to our users with 4.1 and it does not compile, since it is a copy from the /build folder to the /media folder. However in the /build folder it is another level deeper than in the /media folder and thus for example the above file tries to include files by traveling one level to high in the filesystem.

@brianteeman
Copy link
Contributor

How are you trying to compile it?

@Hackwar
Copy link
Member Author

Hackwar commented Jan 27, 2022

I've tried it with the code from #35403.

@richard67
Copy link
Member

@dgrammatiko Could you have a look on this issue? Thanks in advance.

@dgrammatiko
Copy link
Contributor

The scss folder in the media/... is a deliverable and not the source thus they should NOT used (in conjunction with Joomla's own tools) for compiling the css files, for those you need to use the folder build/.... But anyways the PHP compiler should be abandoned as it's not a real replacement of the actual tools for compiling SCSS to CSS...

@Hackwar
Copy link
Member Author

Hackwar commented Jan 27, 2022

However we aren't talking about the PHP compiler, but about the SCSS we are going to ship with 4.1 and that SCSS right now is broken. You can not create an SCSS file which includes that template.scss and run npm to compile it. So please stay on topic.

@Hackwar
Copy link
Member Author

Hackwar commented Jan 27, 2022

If those files aren't meant to be compiled, then delete them now and don't deliver them with our release package.

@dgrammatiko
Copy link
Contributor

You can, the source files are in the build folder...

@dgrammatiko
Copy link
Contributor

If those files aren't meant to be compiled, then delete them now and don't deliver them with our release package.

Yes probably should be removed

@brianteeman
Copy link
Contributor

You can, the source files are in the build folder...

That folder is not distributed

If those files aren't meant to be compiled, then delete them now and don't deliver them with our release package.

Yes probably should be removed

Irrespective of the phpcss thing having the scss for the templates is useful - assuming that the paths are fixed and they can be used.

@Hackwar raises a valid issue here

@dgrammatiko
Copy link
Contributor

@dgrammatiko
Copy link
Contributor

What I'm trying to say is JUST KILL SCSS It was a mistake

@brianteeman
Copy link
Contributor

What I'm trying to say is JUST KILL SCSS It was a mistake

Maybe so but for at least the next 6 months we will be shipping it - so it should be usable

@dgrammatiko
Copy link
Contributor

so it should be usable

Ok will try to do a pr this weekend

@dgrammatiko
Copy link
Contributor

This can be closed

@richard67
Copy link
Member

Closing as having a pull request. Please test #36879 . Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants