Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sass variables for hr background-color and border #35123

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Add Sass variables for hr background-color and border #35123

merged 2 commits into from
Oct 5, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 5, 2021 •
edited
Loading

Replaces #33815, fixes #33793.

@themes4all @devhoussam @mdo
Add Sass variables for hr background-color and border
2a99f89 
Co-Authored-By: Houssam Hammouda <11141564+devhoussam@users.noreply.github.com>
@mdo mdo requested a review from a team as a code owner October 5, 2021 20:43
@mdo mdo mentioned this pull request Oct 5, 2021
Closed
ffoodd
ffoodd approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment •
edited by mdo
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixes #33793, isn't it?

Do we need to check customizations effects for those new variables?

I still don't really see the point, but it has no effect on our standard build so let's go for it 🙂

@mdo mdo merged commit c331a15 into main Oct 5, 2021
@mdo mdo deleted the hr-sass-vars branch October 5, 2021 22:49
@dgrammatiko dgrammatiko mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css release-highlight v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V5 Reboot : Add background-color variable to hr element
3 participants
@mdo @ffoodd @themes4all