Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert alerts to CSS variables #35401

Merged
merged 7 commits into from
Dec 17, 2021
Merged

Convert alerts to CSS variables #35401

merged 7 commits into from
Dec 17, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Nov 26, 2021

No description provided.

@mdo mdo marked this pull request as ready for review November 26, 2021 02:13
@mdo mdo requested a review from a team as a code owner November 26, 2021 02:13
@mdo mdo mentioned this pull request Nov 28, 2021
Open
41 tasks
ffoodd
ffoodd approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Another good candidate for fallback values instead of explicit declarations, almost all custom props are only used once :)

@XhmikosR XhmikosR merged commit f729e4c into main Dec 17, 2021
@XhmikosR XhmikosR deleted the css-vars-alerts branch December 17, 2021 05:16
@ffoodd ffoodd mentioned this pull request Dec 18, 2021
Closed
@dgrammatiko dgrammatiko mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css release-highlight v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdo @ffoodd @XhmikosR