Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error page when no items found in "Compact List of Tagged Items" #39127

Closed
chmst opened this issue Nov 2, 2022 · 4 comments
Closed

Error page when no items found in "Compact List of Tagged Items" #39127

chmst opened this issue Nov 2, 2022 · 4 comments

Comments

@chmst
Copy link
Contributor

chmst commented Nov 2, 2022

Steps to reproduce the issue

Make a menu entry type "Compact List of Tagged Items".
With a tag where no articles or other items are tagged with.

In frontend, click the link.

Expected result

User friendly Information: no items found

Actual result

404 - tag not found.

From the technical point of view the message is correct. For the user it is not.

JROOT\components\com_tags\src\Model\TagModel.php:313

System information (as much as possible)

Additional comments

#39113

@chmst chmst changed the title Error page when no tags no items found in "Compact List of Tagged Items" Error page when no items found in "Compact List of Tagged Items" Nov 2, 2022
@chmst chmst added the UI/UX label Nov 3, 2022
@Hackwar
Copy link
Member

Hackwar commented Nov 5, 2022

I tried this and I can't replicate it on a current 4.3-dev. Can you check this again? The code you mentioned is actually not there to load the content items, but the (list of) tag(s) to use in this menu item. When I tested this, it worked fine. Maybe you had the tag unpublished?

@chmst
Copy link
Contributor Author

chmst commented Nov 5, 2022

I don't remember but after a new test - yes. The 404 appears when the tag is not published.

@Hackwar
Copy link
Member

Hackwar commented Nov 5, 2022

That would then indeed be the right behavior. We do the same when an article is unpublished in a menu item. Therefor I would close this issue for now.

@Hackwar Hackwar closed this as completed Nov 5, 2022
@chmst
Copy link
Contributor Author

chmst commented Nov 5, 2022

I will open a new issue. From a users point of view and this message is technically correct but not user friendly and forums are full with questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants