[4.3] Several fixes to single tag view from com_tags

[Hackwar]

Summary of Changes

This is the result of a codereview of the tag view from com_tags. There are several changes in here, which fix broken behavior in this one view and clean up code. I'm doing my best to document everything in here... This is a complex change, but unfortunately I don't see how to simplify this and/or split this up into several PRs. For all existing sites, this PR will not result in new errors, but rather fix existing issues.

Let's start into the changes in here:

• The view class has been reordered to mimic the article view of com_content. This means, that data is assigned directly to a class attribute and not to a temporary variable, after the data is collected from the model, the parameters are merged appropriately and then the plugin events are run.
• A bunch of docblocks have been fixed.
• The feature to count hits on tags has been moved from the view to the controller, similar to how it is done in com_content. An option to disable this has been added as well.
• $this->item in the view class contains an array of tags and up till now only the first tag was checked against the menu item, etc. Now all the tags are checked.
• At several places, the view class checked the access levels. This is something that we are doing in the model (already) not in the view.
• Merging of parameters was unnecessarily complex.
• In the tag model, the $item attribute wasn't defined. $tag at the same time wasn't used. With $item being initialised as an array, we can remove a bunch of checks. At the same time we can now properly throw a 404 if the number of tag IDs doesn't match the number of tags found in the database matching these IDs. (we might want to rewrite the TagModel::getItem() method to use a single query instead of loading each tag separately with a Table call...)

Testing Instructions

Basically there should be no difference on an existing site between the current code and after applying this PR.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[chmst]

Then I misunderstood that, sorry. I see the problem from your point of view. But as a user I would be ok to know that there is nothing to see. Without 404 error message.

[jamfx]

I have tested this item ✅ successfully on 80c6c27

Testes and no Problems found.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39113.}

[richard67]

I've restored @jamfx 's test result in the issue tracker since the commits which have invalidated the test count were just clean branch updates.

@Hackwar Please avoid unnecessary branch updates since that invalidates the test counter in the issue tracker and so makes it harder for us to find the PRs which have 2 good tests and causes additional work for restoring the test result. Thanks in advance.

[jwaisner]

I have tested this item ✅ successfully on 47f9758

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39113.}

[jwaisner]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39113.}

[cyanama]

I have tested this item ✅ successfully

Please give us customizable css styles for the image and the title. At the moment you need to customize the raw img and h1 statements with impact for the whole webpage.

thanks
Cyana

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39113.}

[richard67]

RTC is still valid because the change after that was just replacing 3 nested if statements by one with the combined condition, which is ok for me by review.

[obuisard]

Thank you Hannes @Hackwar for the PR!