Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] UI issue on MFA in Dark Mode #43448

Closed
dautrich opened this issue May 9, 2024 · 7 comments
Closed

[5.1] UI issue on MFA in Dark Mode #43448

dautrich opened this issue May 9, 2024 · 7 comments

Comments

@dautrich
Copy link

dautrich commented May 9, 2024

Steps to reproduce the issue

  1. Prepare a J5.1 website with a backend user configured to use multiple MFA options (i.e. Passkey as default, TOTP, Backup Codes).
  2. Switch backend to Dark Mode.
  3. Logout and login again with the backend user from 1. by entering userid and password.
  4. On screen “Multifactor Authentication” click “Select a different method”

Expected result

Captions on the following screen are clearly legible.

Actual result

Captions on the following screen are not legible:

grafik

System information (as much as possible)

J5.1.0 (local via Laragon)
Apache 2.4.59
PHP 8.3.8
MySQL 8.0.36

Additional comments

@brianteeman
Copy link
Contributor

The work done in #41799 was not complete and needs to be repeated for administrator\components\com_users\tmpl\captive\select.php

@dautrich
Copy link
Author

dautrich commented Oct 4, 2024

@wilsonge
I just discussed with @coolcat-creations about this issue. She mentioned that you fixed a lot of issues with dark/light mode in your PR #41799 and that this issue might be an easy PR for you.

@coolcat-creations
Copy link
Contributor

I basically repeated what @brianteeman said ;)

@wilsonge
Copy link
Contributor

wilsonge commented Oct 4, 2024

I am getting married tomorrow so unlikely to do this any time soon. Sorry!

@coolcat-creations
Copy link
Contributor

Congrats @wilsonge 😍

@dautrich
Copy link
Author

dautrich commented Oct 5, 2024

@wilsonge All the best wishes for your great event!

@richard67
Copy link
Member

Closing as having a pull request. Please test #44209 . Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants