Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2][Guided Tours] auto start functionality breaks manager user #44080

Closed
heelc29 opened this issue Sep 15, 2024 · 9 comments
Closed

[5.2][Guided Tours] auto start functionality breaks manager user #44080

heelc29 opened this issue Sep 15, 2024 · 9 comments

Comments

@heelc29
Copy link
Contributor

heelc29 commented Sep 15, 2024

Steps to reproduce the issue

  • Create an user and assign it to the “Manager” group
  • Visit the backend

Expected result

no error

Actual result

If you open home dashboard the "Welcome to Joomla!" tour starts
When click "Cancel" or "Hide Forever" an error appears (also when you try to finish the tour)
image

Console Error:
/administrator/index.php?option=com_guidedtours&task=ajax.fetchUserState&format=json&tid=12&sid=1&context=tour.skip

{
    "error": true,
    "code": 403,
    "message": "You don't have permission to access this. Please contact a website administrator if this is incorrect."
}

This error is also present if you try to cancel any other tour.

System information (as much as possible)

j5.2.0-beta3-dev

Additional comments

Caused by #43814
Should be a release blocker

@richard67
Copy link
Member

Ping @obuisard

@obuisard
Copy link
Contributor

I can reproduce the problem. Looking into it.

@obuisard
Copy link
Contributor

It is a permission issue. We call the Ajax controller fetchUserState but the Manager is missing the Access Administration Interface permission for /administrator/index.php?option=com_guidedtours&task=ajax.fetchUserState&format=json&tid=12&sid=1&context=tour.skip to go through

@dautrich
Copy link

I got the identical error message after logging in as Super User when I clicked Complete at the end of the Welcome Tour.

@obuisard
Copy link
Contributor

I got the identical error message after logging in as Super User when I clicked Complete at the end of the Welcome Tour.

@dautrich Rolf, what was the error in the browser console?

@dautrich
Copy link

When I tried for the first time, I didn't have a look at the browser console (shame on me).
I deleted everything (db + directory) and started from scratch. But this time I didn't get any error. Strange!

@obuisard
Copy link
Contributor

When I tried for the first time, I didn't have a look at the browser console (shame on me). I deleted everything (db + directory) and started from scratch. But this time I didn't get any error. Strange!

Thanks, I am glad because it should not happen... But still concerning why it happened the first time.

@obuisard
Copy link
Contributor

I have created a fix. Please wait for PR. I created a Dispatcher for Guided Tours, none was provided.

@richard67
Copy link
Member

Closing as having a pull request. Please test #44082 . Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants