[5.2] [Guided Tours] Fix permission errors when recording user tour state #44082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obuisard
changed the title
brianteeman
reviewed
Sep 16, 2024
|
I have tested this item ✅ successfully on 9af535f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44082. |
Co-authored-by: Brian Teeman <brian@teeman.net>
|
I've restored @brianteeman 's previous test result in the issue tracker as the change after that was only a case change in a language string. |
|
I have tested this item ✅ successfully on 8b919f5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44082. |
|
RTC |
tecpromotion
approved these changes
Sep 17, 2024
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44082. |
|
Thank you for your contribution @obuisard! |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Oct 1, 2024
joomla/joomla-cms#44106 - (только для en-GB) joomla/joomla-cms#44075 + joomla/joomla-cms#44093 + joomla/joomla-cms#43694 + joomla/joomla-cms#44082 + joomla/joomla-cms#44110 - (только для en-GB) joomla/joomla-cms#44111 + joomla/joomla-cms#44105 + joomla/joomla-cms#44146 - (только для др. пакетов) joomla/joomla-cms#44142 + joomla/joomla-cms#44127 - (только для en-GB) joomla/joomla-cms#44132 + joomla/joomla-cms#44137 + joomla/joomla-cms#44145 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44080.
Summary of Changes
The Guided Tours component, until now, did not have a dispatcher.
We do not want to have restrictions on the Ajax call when a tour is running so that any user having access to the administrator console can have its tour state recorder.
Testing Instructions
Create a user with Manager access permissions.
Log as that user.
Either the welcome or the what's new tour should start.
Actual result BEFORE applying this Pull Request
When dismissing the tour (in any way), you get the error:
The state of the tour is not recorded.
Expected result AFTER applying this Pull Request
No more errors.
On an auto-starting tour, the state of the tour is recorded in #__user_profiles table.
If tours are logged, there should be entries in the action logs.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed