Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided Tours] Better tour user state wording and explanation #44093

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

obuisard
Copy link
Contributor

Summary of Changes

To ease user and translators understanding of the tour user states, I have added a comment and improved the wording of the warning messages.

Testing Instructions

None.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on fb1dbc9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44093.

@tecpromotion
Copy link
Contributor

RTC

@Quy
Copy link
Contributor

Quy commented Sep 17, 2024

I have tested this item ✅ successfully on 3816b92


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44093.

@Quy
Copy link
Contributor

Quy commented Sep 17, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44093.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 17, 2024
@Hackwar Hackwar merged commit bb6aade into joomla:5.2-dev Sep 18, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 18, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 18, 2024

Thanks for your contribution @obuisard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants