-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] [Guided Tours] The 'Welcome' tour contains unescaped quotes in a language string #44106
Conversation
If you got to the quotes, then there is an unescaped fragment
|
I have created the PR #44110 |
Thanks Stefan @tecpromotion and Konstantin @Kostelano for the finding and correction! |
I have tested this item ✅ successfully on 4839a83 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44106. |
1 similar comment
I have tested this item ✅ successfully on 4839a83 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44106. |
Thank you for your contribution @obuisard! |
joomla/joomla-cms#44106 - (только для en-GB) joomla/joomla-cms#44075 + joomla/joomla-cms#44093 + joomla/joomla-cms#43694 + joomla/joomla-cms#44082 + joomla/joomla-cms#44110 - (только для en-GB) joomla/joomla-cms#44111 + joomla/joomla-cms#44105 + joomla/joomla-cms#44146 - (только для др. пакетов) joomla/joomla-cms#44142 + joomla/joomla-cms#44127 - (только для en-GB) joomla/joomla-cms#44132 + joomla/joomla-cms#44137 + joomla/joomla-cms#44145 +
Summary of Changes
The 'Welcome' tour has unescaped quotes in a string.
Testing Instructions
Install a fresh instance of this PR.
Actual result BEFORE applying this Pull Request
The 'Welcome' tour runs properly.
Expected result AFTER applying this Pull Request
The 'Welcome' tour runs properly.
You should see:
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed