Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided Tours] The 'Welcome' tour contains unescaped quotes in a language string #44106

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

obuisard
Copy link
Contributor

Summary of Changes

The 'Welcome' tour has unescaped quotes in a string.

Testing Instructions

Install a fresh instance of this PR.

Actual result BEFORE applying this Pull Request

The 'Welcome' tour runs properly.

Expected result AFTER applying this Pull Request

The 'Welcome' tour runs properly.
You should see:

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Contributor

If you got to the quotes, then there is an unescaped fragment fw-medium in the neighboring file.

<p>From <span class="fw-medium">Content -&gt; Site Modules</span> ...

https://github.com/joomla/joomla-cms/blob/4de70ecfea904e6bf3a69a5db8efd4208799b373/administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2.ini#L1C1-L2C70

@tecpromotion
Copy link
Contributor

If you got to the quotes, then there is an unescaped fragment fw-medium in the neighboring file.

<p>From <span class="fw-medium">Content -&gt; Site Modules</span> ...

https://github.com/joomla/joomla-cms/blob/4de70ecfea904e6bf3a69a5db8efd4208799b373/administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2.ini#L1C1-L2C70

I have created the PR #44110
Thank you.

@obuisard
Copy link
Contributor Author

Thanks Stefan @tecpromotion and Konstantin @Kostelano for the finding and correction!

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 4839a83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44106.

1 similar comment
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 4839a83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44106.

@Hackwar Hackwar merged commit 204e5b0 into joomla:5.2-dev Sep 18, 2024
4 of 5 checks passed
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 18, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 18, 2024

Thank you for your contribution @obuisard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants