-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] fix unescaped quotes in sampldata_blog language string #44111
[5.2] fix unescaped quotes in sampldata_blog language string #44111
Conversation
are you sure it is necessary to escape the " for example this is not escaped
or is this another bug to fix? |
I say it's a bug too and in my opinion rel and target should be added as well. |
and add missing rel and target as well
I have tested this item ✅ successfully on e7de066 EDIT I see that you have added a second correction in the meantime. Is this one correct? I would expect the following: Actually this is another bug. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111. |
I have tested this item ✅ successfully on 70c049d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111. |
Thank you for your contribution @tecpromotion! |
joomla/joomla-cms#44106 - (только для en-GB) joomla/joomla-cms#44075 + joomla/joomla-cms#44093 + joomla/joomla-cms#43694 + joomla/joomla-cms#44082 + joomla/joomla-cms#44110 - (только для en-GB) joomla/joomla-cms#44111 + joomla/joomla-cms#44105 + joomla/joomla-cms#44146 - (только для др. пакетов) joomla/joomla-cms#44142 + joomla/joomla-cms#44127 - (только для en-GB) joomla/joomla-cms#44132 + joomla/joomla-cms#44137 + joomla/joomla-cms#44145 +
Pull Request for Issue # .
Summary of Changes
add \
Testing Instructions
code review
Actual result BEFORE applying this Pull Request
class="d-grid gap-2 d-sm-block"
Expected result AFTER applying this Pull Request
class=\"d-grid gap-2 d-sm-block\"
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed