Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] fix unescaped quotes in sampldata_blog language string #44111

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

tecpromotion
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

add \

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

class="d-grid gap-2 d-sm-block"

Expected result AFTER applying this Pull Request

class=\"d-grid gap-2 d-sm-block\"

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Sep 18, 2024
@brianteeman
Copy link
Contributor

brianteeman commented Sep 18, 2024

are you sure it is necessary to escape the "

for example this is not escaped

PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_ARTICLE_4_INTROTEXT="<p>Your site has some commonly used modules already preconfigured. These include:</p><ul><li>Image (type: Custom), which holds the image beneath the menu. This is a Custom module that you can edit to change the image.</li><li>Popular Tags (type: Tags - Popular), which will appear if you use tagging on your articles. Enter a tag in the Tags field when editing.</li><li>Older Posts (type: Articles - Category), which lists out articles by categories.</li><li>Syndication (type: Syndication Feeds), which allows your readers to read your posts in a news reader.</li><li>Login Form (type: Login), which allows your users to access restricted areas of the website.</li></ul><p>Each of these modules has many options which you can experiment with in the Module Manager in your site Administrator. When you are logged in you can also select the edit icon in the top right corner which will take you to an edit screen for that module. Always be sure to save and close any module you edit.</p><p>Joomla! also includes many other modules you can incorporate in your site. As you develop your site you may want to add more modules that you can find at the <a href="https://extensions.joomla.org/">Joomla Extensions Directory.</a></p>"

or is this another bug to fix?

@tecpromotion
Copy link
Contributor Author

or is this another bug to fix?

I say it's a bug too and in my opinion rel and target should be added as well.

@sandewt
Copy link
Contributor

sandewt commented Sep 18, 2024

I have tested this item ✅ successfully on e7de066

code revieuw

EDIT

I see that you have added a second correction in the meantime. Is this one correct?
<a href=\"https://extensions.joomla.org/\" target=\"_blank\" rel=\"noopener noreferrer\">Joomla Extensions Directory.</a>

I would expect the following:
<a href=\"https:\/\/extensions.joomla.org/\" target=\"_blank\" rel=\"noopener noreferrer\">Joomla Extensions Directory.</a>

Actually this is another bug.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111.

@Quy
Copy link
Contributor

Quy commented Sep 18, 2024

I have tested this item ✅ successfully on 70c049d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111.

@Quy
Copy link
Contributor

Quy commented Sep 18, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@Hackwar Hackwar merged commit 1075711 into joomla:5.2-dev Sep 18, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 18, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 18, 2024

Thank you for your contribution @tecpromotion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants