Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for hhvm is out of date and segfaulting with phpunit Issue.
Summary of Changes
Use Trusty build for HHVM to get HHVM 3.13.1 which solves a segfault issue in the HHVM 3.6.x testing
use fast finish to let allow failures continue to run yet still report the completed required tests on time. (trusty builds can be slow)
Note: although this get's us testing on a supported HHVM version and solved the segfault issue, there is still a
Fatal error: request has exceeded memory limit
issue with a test. This test error should not hold back accepting this PR.Testing Instructions
Merge by code review