Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use layouts in the vote plugin #11300

Closed
wants to merge 2 commits into from
Closed

Use layouts in the vote plugin #11300

wants to merge 2 commits into from

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jul 25, 2016

Summary of Changes

This makes it rather easy to customize the voting plugin's output by moving all the logic for the different parts of it to layouts.

Testing Instructions

Apply patch, ensure plugin still renders correctly. Override one of the new layouts (place at templates/<template>/html/plg_content_vote/<layout>.php) and ensure your override is used.

@ghost
Copy link

ghost commented Jul 26, 2016

I have tested this item ✅ successfully on ffc6845


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.

@truptikagathara
Copy link

I have not tested this item.

I am using 5.3.10 version in my setup to test this patch and getting Parse error: syntax error, unexpected '[' in /var/www/joomla-cms/plugins/content/vote/tmpl/vote.php on line 27

I found that line 27 contains $options = []; and error is because of []. As I see joomla should work in 5.3.10 according to https://www.joomla.org/about-joomla/technical-requirements.html I think my test is unsuccessful.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.

@truptikagathara
Copy link

I have tested this item 🔴 unsuccessfully on ffc6845


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.

@ghost
Copy link

ghost commented Jul 26, 2016

I have tested this item ✅ successfully on 342dc1d

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.

@truptikagathara
Copy link

I have tested this item ✅ successfully on 342dc1d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.

@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Jul 27, 2016
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.0 milestone Jul 27, 2016
@wilsonge
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 27, 2016
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Jul 27, 2016
wilsonge pushed a commit that referenced this pull request Jul 30, 2016
@wilsonge
Copy link
Contributor

Merged with 99f9c5f - Thanks!

@wilsonge wilsonge closed this Jul 30, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 30, 2016
@mbabker mbabker deleted the vote-plugin-layouts branch October 27, 2016 12:41
@zero-24 zero-24 mentioned this pull request Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants