Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7.x] Fix typo in the isis css file #12346

Closed
wants to merge 3 commits into from
Closed

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Oct 7, 2016

Pull Request for Issue raised here: #12319 (comment)

Summary of Changes

Fiy typo on fixing conflicts

Testing Instructions

review

Documentation Changes Required

None

@zero-24
Copy link
Contributor Author

zero-24 commented Oct 7, 2016

hmm i did get a different diff please double check that @C-Lodder @ciar4n

@C-Lodder
Copy link
Member

C-Lodder commented Oct 7, 2016

This need to be done in the LESS file.

@zero-24 - It was a 1px difference for the blue background.

@ciar4n
Copy link
Contributor

ciar4n commented Oct 7, 2016

@C-Lodder The LESS file appears to be correct (-26px). When compiled it changes the CSS from -25px to -26px. Although we should also be seeing a similar change in the template-rtl.css

@zero-24 Have the changes here been the result of the LESS been compiled or have you edited the CSS directly?

@zero-24
Copy link
Contributor Author

zero-24 commented Oct 7, 2016

Should be correct now? All three places have now -26px

@ciar4n
Copy link
Contributor

ciar4n commented Oct 7, 2016

Here is the CSS compiled from the LESS files.. ciar4n@350807b

@zero-24
Copy link
Contributor Author

zero-24 commented Oct 7, 2016

done thanks @ciar4n and @C-Lodder

@zero-24 zero-24 removed this from the Joomla 3.7.0 milestone Oct 8, 2016
@zero-24
Copy link
Contributor Author

zero-24 commented Oct 8, 2016

fixed with: #12349

@zero-24 zero-24 closed this Oct 8, 2016
@zero-24 zero-24 deleted the typo branch October 8, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants