[com_fields] - Creating a New field give SQL error on postgresql

[alikon]

Pull Request for Issue #13137 .

Summary of Changes

add a check for group_id

Testing Instructions

Create a new field see #13137 (comment)

[Bakual]

We could also specify the option value as 0 in https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/models/forms/field.xml#L31

[laoneo]

I would also put it into the XML and for safety, define the 0 as default value.

[alikon]

Ok I'll add the XML part

[alikon]

xml deafult added

[laoneo]

Should the different installer scripts not be coherent to each other. In MySQL we default the value to 0 https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L643.

[Bakual]

The issue is that PostgreSQL works differently (more strict) than MySQL. The default is defined as 0 in PostgreSQL as well (see https://github.com/joomla/joomla-cms/blob/staging/installation/sql/postgresql/joomla.sql#L656) but we try to store an empty string there. MySQL just changes the invalid value to the default. PostgreSQL rightfully rejects it as an invalid value and throws an error.

[alikon]

At least we have this already fixed for j4 where mysql should be in strict mode ;)

[waader]

I have tested this item ✅ successfully on 335026a

The error has gone. Thanks alikon!

Two things I noticed:

• the "field group" field in "articles field:edit" now shows 0 as default value
• a "field group" with assigned fields is not shown in "articles:edit"

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13155.}

[ralain]

@alikon Perhaps this should be changed to <option value="0">JNONE</option> to avoid the nonsensical "0" in the field group select.

[alikon]

thanks added

[ralain]

I have tested this item ✅ successfully on ae96b42

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13155.}

[zero-24]

Merged thanks!