[com_fields] Don't default to all user fields to show

[laoneo]

Pull Request for Issue #14392.

Summary of Changes

Don't default to all user groups to show on contact fields. Like it is now it is not possible to prevent to show the user custom fields on the contact details. This pr removes the hardcoded default value "All".

Testing Instructions

Clear the "Show User Custom Fields" option in the contact options.

Expected result

Keep empty.

Actual result

Defaults the value to "All".

Documentation Changes Required

[gwsdesk]

I have tested this item 🔴 unsuccessfully on d140e0f

I have tested this unsuccessfully See https://www.screencast.com/t/dDPWttlRH

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.}

[gwsdesk]

See the reason and what is happening https://www.screencast.com/t/dDPWttlRH

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.}

[laoneo]

Found a browser with flash. Do you mean the cut text which is wrong? There is already an issue open #13594.

[gwsdesk]

Not sure @laoneo
If I empty the field and save I get the broken cut text. If I load the options initially the "All"is given in the field entry. Changing it to empty and successively saving and reloading gives that behavior. So not sure actually what should be shown after empty and save.....should it show "all" or empty (with correct text)

[laoneo]

It should be an empty select box as in your screencast. The broken text is a "bug" in the template as discussed in #13594. So I guess we should handle the cut text problem in the issue. Is the rest working as expected?

[gwsdesk]

Correct works as expected for the prevention so will change the test result Thanks Allon

[gwsdesk]

I have tested this item ✅ successfully on d140e0f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.}

[coolcat-creations]

I have tested this item 🔴 unsuccessfully on d140e0f

The userfields are still show, although nothing is selected

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.}

[laoneo]

Is it empty in the menu configuration and the global contact options?

[coolcat-creations]

Yes both are empty, also created a completely new one as the existing failed, but also no luck

[brianteeman]

I have tested this item 🔴 unsuccessfully on d140e0f

I created a user field group called testgroup
I create a user text field called textfield
I created a contsct and linked it to a user
I created a menu item to display a single contact
I checked that the option field did not have a category set
The contact is displayed on the front end with both the group and its fields

Just a guess but instead of having it blank would it not be better to have a NONE setting

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.}

[laoneo]

The important point is that the setting in the global contact options is not defaulted to all. So make sure that you can save it with no value selected and it stay like that:

As soon as I select a group or All, then the fields do show up, but when none is selected, then no fields should be shown.

[brianteeman]

As stated above in my report it is not enough for the options page to show no value. it actually has to work in that way which it doesnt

[laoneo]

I'v just tested it with your instructions and when the field is empty, then it shows no fields on the contact page. So for me it is working as expected. I'v just tested it with the latest staging.

[brianteeman]

ok let me test again with latest staging

[brianteeman]

Ignore me I was being an idiot. All good

[brianteeman]

I have tested this item ✅ successfully on 691b8cf

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.}

[laoneo]

Glad to hear it is working as expected.

[laoneo]

@gwsdesk can you test it again as it doesn't count your test because of the upstream merge. Thanks.

[ghost]

I have tested this item ✅ successfully on 691b8cf

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.}

[ghost]

RTC after two successful testes.