Allow different buttons setup for tinyMCE

[dgrammatiko]

Pull Request complimentary for Issue #14390 .

Summary of Changes

Pass different params for each instance of tinyMCE

Testing Instructions

• In the global configuration select Tynimce as your default editor.

• Create a new Editor custom field.

• Select the Show Buttons as YES!

• Select in the next input the buttons you want to hide.

• Save the field.

• Create a new article

• Repeat the process but making Show Buttons as NO!

Expected result

Buttons behave according to the given input

Documentation Changes Required

This might not be B/C compatible (depending the tinyMCE introduced the Joomla.storageOptions)

[zero-24]

This might not be B/C compatible (depending the tinyMCE introduced the Joomla.storageOptions)

As this was done in 3.7 this is not a problem right?

[dgrammatiko]

I couldn't find the PR for that, thanks for clearing this out

[zero-24]

should be this here: #11157 @DGT41

[dgrammatiko]

@Fedik can you review the changes here?

[laoneo]

Is this ready for testing?

[dgrammatiko]

Yup

[laoneo]

I have tested this item ✅ successfully on d8d404c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14417.}

[infograf768]

I have tested this item ✅ successfully on d8d404c

Works nicely.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14417.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14417.}

[Fedik]

I am afraid this is not compatible with subform,
There the id will be generated by JS, therefore the new editor instances (added in new row by JS) will not have any defined options while call Joomla.getOptions('plg_editor_tinymce_' + editor.id, {})

[Fedik]

@DGT41 I am afraid it will fail in multiple cases

but, there is possibility to override default options for the editor by the editor field name, introduced in #11157, maybe we can use it somehow here. Also 'default' options are cached.

[infograf768]

shall rtc be removed?

[dgrammatiko]

yup, let's figure out another way for this

[infograf768]

back to pending

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14417.}

[coolcat-creations]

Would be great if it will be possible, i ran into this today :) 👍

[dgrammatiko]

@Fedik how about: 54c3a5a

[Fedik]

@DGT41 could work, but still not perfect 😉
did you seen, there already test for "whether default parameters loaded"? 😉 https://github.com/dgt41/joomla-cms/blob/5d1b0d995fd96582116a5813884f0ece31ae0f65/plugins/editors/tinymce/tinymce.php#L203

I think here need something like:

// Load default:
if (empty($options['tinyMCE']['default'])) {
  $options['tinyMCE']['default'] = array(/* default, general, params*/)
}

// Load changes for current name
$options['tinyMCE']['fieldName']['toolbar1'] = 'blabla';

[dgrammatiko]

@Fedik I know, but the other option needs a lot of refactoring and due to the legacy method is double work. We can postpone it for J4 when we will do the clean up.

[Fedik]

I know

then you should note that adding if (!$this->defaultParamsLoaded) make no difference 😉

but the other option needs a lot of refactoring and due to the legacy method is double work.

true, but current solution with _' . $id introduce more mess , I think

I try to check more, this weekend, if will get some time 😉

[Fedik]

@DGT41 check this #14520

[dgrammatiko]

there is a new PR #14520