-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com_fields] Add support for max length for text and textarea #14458
Conversation
I have tested this item ✅ successfully on 4eccfc1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458. |
@@ -8,5 +8,7 @@ PLG_FIELDS_TEXT_LABEL="Text (%s)" | |||
PLG_FIELDS_TEXT_PARAMS_FILTER_LABEL="Filter" | |||
PLG_FIELDS_TEXT_PARAMS_FILTER_DESC="Allow the system to save certain html tags or raw data." | |||
PLG_FIELDS_TEXT_PARAMS_FILTER_RAW="Raw" | |||
PLG_FIELDS_TEXT_PARAMS_MAXLENGTH_LABEL="Max Length" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maximum Length
This is more consistent with elsewhere
@@ -8,5 +8,7 @@ PLG_FIELDS_TEXT_LABEL="Text (%s)" | |||
PLG_FIELDS_TEXT_PARAMS_FILTER_LABEL="Filter" | |||
PLG_FIELDS_TEXT_PARAMS_FILTER_DESC="Allow the system to save certain html tags or raw data." | |||
PLG_FIELDS_TEXT_PARAMS_FILTER_RAW="Raw" | |||
PLG_FIELDS_TEXT_PARAMS_MAXLENGTH_LABEL="Max Length" | |||
PLG_FIELDS_TEXT_PARAMS_MAXLENGTH_DESC="Limits the number of characters that may be entered." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The maximum number of characters that can be entered.
This is more accurate and consistent with elsewhere
Changed. Perhaps somebody should change the docs as well https://docs.joomla.org/Text_form_field_type. |
I have tested this item ✅ successfully on d633af8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458. |
1 similar comment
I have tested this item ✅ successfully on d633af8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458. |
@laoneo can you please look at the conflicts? |
COnflicts solved. |
@coolcat-creations and @franz-wohlkoenig can you please re-test? |
Again conflicts solved, can we set this one to RTC? |
I have tested this item ✅ successfully on b1e8a04 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458. |
1 similar comment
I have tested this item ✅ successfully on b1e8a04 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458. |
RTC as there are 2 successfully Tests? |
Just merged staging into this branch, can be set to RTC. |
I have tested this item ✅ successfully on aed12c4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458. |
Sorry , my mistake. My post was intended for #14558 . This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458. |
Can we set this one to RTC as well? |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458. |
Pull Request for Issue #14374.
Summary of Changes
Adds the max length parameter to the text and textarea custom field. Additionally it fixes a bug in the maxlength parameter of the JLayout of the textarea field.
Testing Instructions
Expected result
It should not be possible to add more than 2 characters into the text field when editing the article.
Actual result
The max length parameter is not available as it is a new feature.
Documentation Changes Required
Adding the max length parameter description to the text and textarea field in the documentation pages.