Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codestyle] admin non-components xml files #15922

Merged
merged 23 commits into from
Jun 4, 2017
Merged

[codestyle] admin non-components xml files #15922

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
69154c9
Codestyle
brianteeman May 9, 2017
3160ba9
indent
brianteeman May 9, 2017
e496c29
order
brianteeman May 9, 2017
8b2075d
oops
brianteeman May 9, 2017
e452c49
changes requested by @andrepereiradasilva
brianteeman May 31, 2017
1ff29d6
cs
brianteeman May 31, 2017
8977d09
Merge branch 'staging' into xml_code_admin_rest
brianteeman May 31, 2017
a3672c9
changes requested by @wojsmol
brianteeman May 31, 2017
ca05381
Update mod_logged.xml (#43)
May 31, 2017
8a90e1e
Update templateDetails.xml (#45)
May 31, 2017
dfddfd5
Update mod_popular.xml (#44)
May 31, 2017
8efc76e
Update templateDetails.xml (#57)
May 31, 2017
ec9e060
Update mod_version.xml (#56)
May 31, 2017
27c5689
Update mod_toolbar.xml (#55)
May 31, 2017
796ce03
Update mod_title.xml (#54)
May 31, 2017
3c41873
Update mod_submenu.xml (#53)
May 31, 2017
27b384f
Update mod_status.xml (#52)
May 31, 2017
df52190
Update mod_stats_admin.xml (#51)
May 31, 2017
3f2e02d
Update mod_quickicon.xml (#50)
May 31, 2017
b122513
Update mod_menu.xml (#49)
May 31, 2017
43ddad4
Update mod_login.xml (#48)
May 31, 2017
dd40901
Update mod_latest.xml (#47)
May 31, 2017
02f7018
Update mod_feed.xml (#46)
May 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions administrator/modules/mod_custom/mod_custom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@
name="prepare_content"
type="radio"
label="MOD_CUSTOM_FIELD_PREPARE_CONTENT_LABEL"
class="btn-group btn-group-yesno"
description="MOD_CUSTOM_FIELD_PREPARE_CONTENT_DESC"
default="1">
class="btn-group btn-group-yesno"
default="1"
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
Expand All @@ -41,32 +42,34 @@
name="layout"
type="modulelayout"
label="JFIELD_ALT_LAYOUT_LABEL"
description="JFIELD_ALT_MODULE_LAYOUT_DESC" />
description="JFIELD_ALT_MODULE_LAYOUT_DESC"
/>

<field
name="moduleclass_sfx"
type="textarea" rows="3"
label="COM_MODULES_FIELD_MODULECLASS_SFX_LABEL"
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC" />
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC"
/>

<field
name="cache"
type="list"
default="1"
label="COM_MODULES_FIELD_CACHING_LABEL"
description="COM_MODULES_FIELD_CACHING_DESC">
<option
value="1">JGLOBAL_USE_GLOBAL</option>
<option
value="0">COM_MODULES_FIELD_VALUE_NOCACHING</option>
description="COM_MODULES_FIELD_CACHING_DESC"
default="1"
>
<option value="1">JGLOBAL_USE_GLOBAL</option>
<option value="0">COM_MODULES_FIELD_VALUE_NOCACHING</option>
</field>

<field
name="cache_time"
type="text"
default="900"
label="COM_MODULES_FIELD_CACHE_TIME_LABEL"
description="COM_MODULES_FIELD_CACHE_TIME_DESC" />
description="COM_MODULES_FIELD_CACHE_TIME_DESC"
default="900"
/>
</fieldset>
</fields>
</config>
Expand Down
87 changes: 46 additions & 41 deletions administrator/modules/mod_feed/mod_feed.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,59 +25,59 @@
<field
name="rssurl"
type="url"
label="MOD_FEED_FIELD_RSSURL_LABEL"
description="MOD_FEED_FIELD_RSSURL_DESC"
filter="url"
size="50"
required="true"
validate="url"
label="MOD_FEED_FIELD_RSSURL_LABEL"
description="MOD_FEED_FIELD_RSSURL_DESC" />
/>

<field
name="rssrtl"
type="radio"
label="MOD_FEED_FIELD_RTL_LABEL"
description="MOD_FEED_FIELD_RTL_DESC"
class="btn-group btn-group-yesno"
default="0"
label="MOD_FEED_FIELD_RTL_LABEL"
description="MOD_FEED_FIELD_RTL_DESC">
<option
value="1">JYES</option>
<option
value="0">JNO</option>
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>

<field
name="rsstitle"
type="radio"
label="MOD_FEED_FIELD_RSSTITLE_LABEL"
description="MOD_FEED_FIELD_RSSTITLE_DESC"
class="btn-group btn-group-yesno"
default="1"
label="MOD_FEED_FIELD_RSSTITLE_LABEL"
description="MOD_FEED_FIELD_RSSTITLE_DESC">
<option
value="1">JYES</option>
<option
value="0">JNO</option>
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>

<field
name="rssdesc"
type="radio"
label="MOD_FEED_FIELD_DESCRIPTION_LABEL"
description="MOD_FEED_FIELD_DESCRIPTION_DESC"
class="btn-group btn-group-yesno"
default="1"
label="MOD_FEED_FIELD_DESCRIPTION_LABEL"
description="MOD_FEED_FIELD_DESCRIPTION_DESC">
<option
value="1">JYES</option>
<option
value="0">JNO</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options deleted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojsmol they are ok now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianteeman corected this in 8b2075d.

>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
<field
name="rssimage"
type="radio"
label="MOD_FEED_FIELD_IMAGE_LABEL"
description="MOD_FEED_FIELD_IMAGE_DESC"
class="btn-group btn-group-yesno"
default="1"
label="MOD_FEED_FIELD_IMAGE_LABEL"
description="MOD_FEED_FIELD_IMAGE_DESC">
<option
value="1">JYES</option>
<option
value="0">JNO</option>
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
<field
name="rssitems"
Expand All @@ -88,43 +88,47 @@
<field
name="rssitemdesc"
type="radio"
label="MOD_FEED_FIELD_ITEMDESCRIPTION_LABEL"
description="MOD_FEED_FIELD_ITEMDESCRIPTION_DESC"
class="btn-group btn-group-yesno"
default="1"
label="MOD_FEED_FIELD_ITEMDESCRIPTION_LABEL"
description="MOD_FEED_FIELD_ITEMDESCRIPTION_DESC">
<option
value="1">JYES</option>
<option
value="0">JNO</option>
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
<field
name="word_count"
type="text"
label="MOD_FEED_FIELD_WORDCOUNT_LABEL"
description="MOD_FEED_FIELD_WORDCOUNT_DESC"
size="6"
default="0"
label="MOD_FEED_FIELD_WORDCOUNT_LABEL"
description="MOD_FEED_FIELD_WORDCOUNT_DESC" />
/>
</fieldset>
<fieldset
name="advanced">
<field
name="layout"
type="modulelayout"
label="JFIELD_ALT_LAYOUT_LABEL"
description="JFIELD_ALT_MODULE_LAYOUT_DESC" />
description="JFIELD_ALT_MODULE_LAYOUT_DESC"
/>

<field
name="moduleclass_sfx"
type="textarea" rows="3"
type="textarea"
label="COM_MODULES_FIELD_MODULECLASS_SFX_LABEL"
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC" />
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC"
rows="3"
/>

<field
name="cache"
type="list"
default="1"
label="COM_MODULES_FIELD_CACHING_LABEL"
description="COM_MODULES_FIELD_CACHING_DESC">
description="COM_MODULES_FIELD_CACHING_DESC"
default="1"
>
<option
value="1">JGLOBAL_USE_GLOBAL</option>
<option
Expand All @@ -134,9 +138,10 @@
<field
name="cache_time"
type="text"
default="900"
label="COM_MODULES_FIELD_CACHE_TIME_LABEL"
description="COM_MODULES_FIELD_CACHE_TIME_DESC" />
description="COM_MODULES_FIELD_CACHE_TIME_DESC"
default="900"
/>
</fieldset>
</fields>
</config>
Expand Down
42 changes: 24 additions & 18 deletions administrator/modules/mod_latest/mod_latest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,38 +25,43 @@
<field
name="count"
type="text"
default="5"
label="MOD_LATEST_FIELD_COUNT_LABEL"
description="MOD_LATEST_FIELD_COUNT_DESC" />
description="MOD_LATEST_FIELD_COUNT_DESC"
default="5"
/>

<field
name="ordering"
type="list"
default="c_dsc"
label="MOD_LATEST_FIELD_ORDERING_LABEL"
description="MOD_LATEST_FIELD_ORDERING_DESC">
description="MOD_LATEST_FIELD_ORDERING_DESC"
default="c_dsc"
>
<option
value="c_dsc">MOD_LATEST_FIELD_VALUE_ORDERING_ADDED</option>
<option
value="m_dsc">MOD_LATEST_FIELD_VALUE_ORDERING_MODIFIED</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposed improvement: option in a single line

</field>

<field
id="catid"
name="catid"
type="category"
extension="com_content"
label="JCATEGORY"
description="MOD_LATEST_FIELD_CATEGORY_DESC"
id="catid"
extension="com_content"
default=""
>
<option
value="">JOPTION_ANY_CATEGORY</option>
<option value="">JOPTION_ANY_CATEGORY</option>
</field>

<field
name="user_id"
type="list"
default="0"
label="MOD_LATEST_FIELD_AUTHORS_LABEL"
description="MOD_LATEST_FIELD_AUTHORS_DESC">
description="MOD_LATEST_FIELD_AUTHORS_DESC"
default="0"
>
<option
value="0">MOD_LATEST_FIELD_VALUE_AUTHORS_ANYONE</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposed improvement: option in a single line

<option
Expand All @@ -71,25 +76,26 @@
name="layout"
type="modulelayout"
label="JFIELD_ALT_LAYOUT_LABEL"
description="JFIELD_ALT_MODULE_LAYOUT_DESC" />
description="JFIELD_ALT_MODULE_LAYOUT_DESC"
/>

<field
name="moduleclass_sfx"
type="textarea" rows="3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rows goes down

label="COM_MODULES_FIELD_MODULECLASS_SFX_LABEL"
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC" />
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC"
/>

<field
name="automatic_title"
type="radio"
label="COM_MODULES_FIELD_AUTOMATIC_TITLE_LABEL"
description="COM_MODULES_FIELD_AUTOMATIC_TITLE_DESC"
class="btn-group btn-group-yesno"
default="0"
label="COM_MODULES_FIELD_AUTOMATIC_TITLE_LABEL"
description="COM_MODULES_FIELD_AUTOMATIC_TITLE_DESC">
<option
value="1">JYES</option>
<option
value="0">JNO</option>
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
</fieldset>
</fields>
Expand Down
28 changes: 16 additions & 12 deletions administrator/modules/mod_logged/mod_logged.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,16 @@
type="text"
default="5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default goes down

label="MOD_LOGGED_FIELD_COUNT_LABEL"
description="MOD_LOGGED_FIELD_COUNT_DESC" />
description="MOD_LOGGED_FIELD_COUNT_DESC"
/>

<field
name="name"
type="list"
default="1"
label="MOD_LOGGED_NAME"
description="MOD_LOGGED_FIELD_NAME_DESC" >
description="MOD_LOGGED_FIELD_NAME_DESC"
default="1"
>
<option
value="1">MOD_LOGGED_NAME</option>
<option
Expand All @@ -45,25 +47,27 @@
name="layout"
type="modulelayout"
label="JFIELD_ALT_LAYOUT_LABEL"
description="JFIELD_ALT_MODULE_LAYOUT_DESC" />
description="JFIELD_ALT_MODULE_LAYOUT_DESC"
/>

<field
name="moduleclass_sfx"
type="textarea" rows="3"
type="textarea"
label="COM_MODULES_FIELD_MODULECLASS_SFX_LABEL"
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC" />
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC"
rows="3"
/>

<field
name="automatic_title"
type="radio"
label="COM_MODULES_FIELD_AUTOMATIC_TITLE_LABEL"
description="COM_MODULES_FIELD_AUTOMATIC_TITLE_DESC"
class="btn-group btn-group-yesno"
default="0"
label="COM_MODULES_FIELD_AUTOMATIC_TITLE_LABEL"
description="COM_MODULES_FIELD_AUTOMATIC_TITLE_DESC">
<option
value="1">JYES</option>
<option
value="0">JNO</option>
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
</fieldset>
</fields>
Expand Down
14 changes: 9 additions & 5 deletions administrator/modules/mod_login/mod_login.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@
<field
name="usesecure"
type="radio"
label="MOD_LOGIN_FIELD_USESECURE_LABEL"
description="MOD_LOGIN_FIELD_USESECURE_DESC"
class="btn-group btn-group-yesno"
default="0"
label="MOD_LOGIN_FIELD_USESECURE_LABEL"
description="MOD_LOGIN_FIELD_USESECURE_DESC">
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
Expand All @@ -39,13 +40,16 @@
name="layout"
type="modulelayout"
label="JFIELD_ALT_LAYOUT_LABEL"
description="JFIELD_ALT_MODULE_LAYOUT_DESC" />
description="JFIELD_ALT_MODULE_LAYOUT_DESC"
/>

<field
name="moduleclass_sfx"
type="textarea" rows="3"
type="textarea"
label="COM_MODULES_FIELD_MODULECLASS_SFX_LABEL"
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC" />
description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC"
rows="3"
/>

</fieldset>
</fields>
Expand Down
Loading