Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the root user configuration to any superadmin when enabeld #18135

Merged
merged 3 commits into from
Oct 5, 2017

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Sep 26, 2017

Summary of Changes

Show the root user configuration to any superadmin when enabeld

Testing Instructions

  • create a user called "test1" with publisher permissions
  • add public $root_user = 'test1'; to the configuration.php
  • login to the backend using a other superadmin
  • login to the backend using the user test1

post patch result

A message to the logged in root user and for any other superadmin also this message is not a error and not a notice anymore

test 1

image

other superadmin

image

pre patch result

Just a message to the logged in root user.

Documentation Changes Required

none

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Sep 26, 2017
Change text to be consistent with documentation
@Quy
Copy link
Contributor

Quy commented Sep 27, 2017

Oops. That makes sense. I assume this will have to be changed.

PLG_SYSTEM_STATS_MSG_WHAT_DATA_WILL_BE_SENT="Click here to see the information that will be sent."

@Quy
Copy link
Contributor

Quy commented Sep 29, 2017

I have tested this item ✅ successfully on 0a0bf28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18135.

1 similar comment
@n9iels
Copy link
Contributor

n9iels commented Sep 30, 2017

I have tested this item ✅ successfully on 0a0bf28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18135.

@zero-24 zero-24 added this to the Joomla 3.8.2 milestone Sep 30, 2017
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.2 milestone Sep 30, 2017
@ghost
Copy link

ghost commented Sep 30, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 30, 2017
@mbabker mbabker added this to the Joomla 3.8.2 milestone Oct 5, 2017
@mbabker mbabker merged commit 4040b20 into joomla:staging Oct 5, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 5, 2017
@zero-24 zero-24 deleted the rootuser_notification branch October 6, 2017 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants