Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Drop GMail Plugin from 4.0 new installs #18322

Merged
merged 3 commits into from
Mar 31, 2018
Merged

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Oct 12, 2017

Pull Request for Issue #18310 .

Testinstructions

Expected result

No GMail Plugin in 4.0 new installs. If needed it can be installed from a joomla-extensions repo.

Actual result

There is a gmail plugin in the core that is disabled by default + require to enable allow less secure apps setting in the google account.

RFC

Please leave your opinions on this topic below ;)

@laoneo
Copy link
Member

laoneo commented Oct 18, 2017

Agree, we should get rid of it.

@zero-24
Copy link
Contributor Author

zero-24 commented Jan 13, 2018

Any more opinions here? I don't want to waste my time in fixing the conflicts where there are already different decisions done. cc @wilsonge ;)

@zero-24 zero-24 added the RFC Request for Comment label Jan 13, 2018
@wilsonge
Copy link
Contributor

Go for it. Let's get rid of it

@Bakual
Copy link
Contributor

Bakual commented Jan 23, 2018

Can we put some message in it for the updating users that says it is unsupported? Eg in the description.

@Bakual
Copy link
Contributor

Bakual commented Jan 23, 2018

If needed it can be installed from a joomla-extensions repo.

Personally, I wouldn't put it in a joomla-extensions repo. That would mean we still have to support it and need to properly "extract" it from core (eg add updateservers) like we did with Weblinks. Just drop it instead.
We should think a bit more about the users who update. Because essentially we leave them with unsupported code in their system. That isn't nice.
for those who have it not enabled, we could actually unistall and delete the plugin automatically. For those who have it active, we should give them a note that they need to find another solution.

@brianteeman
Copy link
Contributor

my understanding is that all removed code is being added to the script.php as before but its being done by @wilsonge in batches instead of it being in the pr

@peteruoi
Copy link

I am not sure what's the reasoning for this decision?
Not many people use it?
Probably but some sure do.
Decoupling? Are we sure we want all plugins the weblinks way?
Maintenance cost?
I 'd say zero but in any case there will be the same maintenace in the joomla maintenace repo (if someone will look over it...)
Do we get rid some jquery library cause of it?
Imho the gain of this is that the plugin manager will have one less plugin.
Is it worth?
I 'm not developer-specialist just a joomla fun and site builder.
There is a tendency to smaller cleaner core and then let the builder go through jet to search for everything but i like when i can do most of the basec thing with core :)

@brianteeman
Copy link
Contributor

brianteeman commented Jan 23, 2018

Sorry i completely missed something when writing my comment
Removing it from new installs will of course mean that it is still present on upgrades as we dont know if it is being used or not. We could add a message or even change the title of the plugin to "unsupported" but then we will be in a situation where there is code installed on the site that is not in the github repo here which will make support/security checks difficult.
So yes Thomas is correct it is not as simple as just removing it from "new" installs

@dgrammatiko
Copy link
Contributor

Do we get rid some jquery library cause of it?

Joomla 4 will not use jQuery although the API (JHtml::_('behavior.jquery');) will still available for the old timers

@peteruoi
Copy link

i know this. Maybe i didn't express myself well.
I meant we are not going to have an advantage such us removing a dependency of something if we drop the gmail plugin.

@Bakual
Copy link
Contributor

Bakual commented Mar 13, 2018

Why are you dropping such handy Gmail plugin?

Because it is a perfect example of something which should be done by 3rd parties, not core.

@joomla joomla deleted a comment Mar 13, 2018
@brianteeman
Copy link
Contributor

Deleted spam comment

@zero-24
Copy link
Contributor Author

zero-24 commented Mar 31, 2018

Any update on this one @wilsonge ? I have just updated that pr & travis is broken on 4.0 in general 😄

@laoneo laoneo merged commit f925beb into joomla:4.0-dev Mar 31, 2018
@laoneo
Copy link
Member

laoneo commented Mar 31, 2018

Thanks!!

@brianteeman
Copy link
Contributor

:(

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 31, 2018
@zero-24 zero-24 deleted the drop_gmail branch March 31, 2018 22:12
@wilsonge
Copy link
Contributor

wilsonge commented Apr 1, 2018

For others reference there’s lots of marketing work going on behind the scenes on this. Expect to see blog posts etc sooner rather than later.

@brianteeman
Copy link
Contributor

If people used https://volunteers.joomla.org/reports it would save a lot of comment

@laoneo laoneo changed the title [RFC] Drop GMail Plugin from 4.0 new installs Drop GMail Plugin from 4.0 new installs Apr 3, 2018
@joomla-cms-bot joomla-cms-bot removed the RFC Request for Comment label Apr 3, 2018
@zero-24 zero-24 changed the title Drop GMail Plugin from 4.0 new installs [4.0] Drop GMail Plugin from 4.0 new installs Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants