JController::factory() and createEnvironmentArray() as discussed in joomla-dev-cms group #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) factory() 2) createEvenrinmentArray() 3) setTask($task) Changed execute($task) that if no task is passed, it executes the $this->task (which is set also by the factory method) 2012-04-19 by Duccio Gasparri <duccio.gasparri@gmail.com> Change-Id: I2a4ded062856670e364128f3cb74716b84b23eea
|
getInstance() should also be cleaned and simplified, as it does stuff proper of a factory pattern and factory method (choosing which class to load). Not knowing if there was backward compatibility issues, I left it like that. Part of the "reasoning" in getInstance() about the environment variables ($_REQUEST task, controller, option, and so on) are left intact in the getInstance(), but were duplicated cleared and streamlined into the createEnvironmentArray() method. |
| public static function createEnvironmentArray($option = null, $component = null, $controller = null, $task = null, $format = null, $basePath = null) | ||
| { | ||
|
|
||
| $jinput = JApplication::getInput(); |
There was a problem hiding this comment.
That method doesn't exist. Correct would be JFactory::getApplication()->input.
|
I'm closing this as it's not mergeable and 1 year old. Feel free to open if you update it and are still interested in get it merged. Thanks for contributing. |
wilsonge
pushed a commit
that referenced
this pull request
Jun 4, 2017
* Added PlgFileSystemLocal test * Moved LocalAdapterTest to plugins/filesystem/local * Added unit test for PlgFileSystemLocal * Updated description
hans2103
pushed a commit
to hans2103/joomla-cms
that referenced
this pull request
Nov 18, 2020
Remove double underline in menu (top position) Remove underline for span items in menu Add margin to nav and search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to JController the following methods:
Changed execute($task) that if no task is passed, it executes the
$this->task (which is set also by the factory method)
See discussion https://groups.google.com/forum/?fromgroups#!topic/joomla-dev-cms/7tjVkzc08Ks (Object oriented components , any plan?)
2012-04-19 by Duccio Gasparri duccio.gasparri@gmail.com
Change-Id: I2a4ded062856670e364128f3cb74716b84b23eea