Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion of "poster" attribute URL in SEF plugin #197

Closed
wants to merge 3 commits into from
Closed

Add conversion of "poster" attribute URL in SEF plugin #197

wants to merge 3 commits into from

Conversation

ryandemmer
Copy link
Contributor

The SEF plugin does not convert the HTML5 poster attribute URL.

This commit adds the "poster" attribute to the regex alongside the "src and "href" attributes.

Tracker - http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27711

@infograf768
Copy link
Member

Ryan, pelase create a joomalcode tracker and cross-reference here,

@ryandemmer
Copy link
Contributor Author

The tracker already exists, I have posted a response to it - http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27711

@infograf768
Copy link
Member

Please separate issues. We are here dealing with the sef plugin only.
I suggest you first propose the new library function to platform.

@ryandemmer
Copy link
Contributor Author

Sorry I don't know how to separate the requests and I didn't realise Github would add them together.

Should I close and re-open the pull request?

@realityking
Copy link
Contributor

@infograf768 you should be able to just apply this patch: https://github.com/ryandemmer/joomla-cms/commit/f811241c5432521c3979d0ba1a40c6ed34612ee5.diff

@ryandemmer If you make a pull request based on a branch all new commits you push into that branch will be part of the pull request

@infograf768
Copy link
Member

@ryandemmer
as it is a library file patch, I suggest you create a pull to platform first.
Let's keep this one as is. I will close it after committing the part needed.

@nicksavov
Copy link
Contributor

This is fixed in JoomlaCode. Thanks for coding this, Ryan! :)

Closing.

@nicksavov nicksavov closed this Mar 29, 2013
wilsonge pushed a commit that referenced this pull request Jun 4, 2017
wilsonge pushed a commit to wilsonge/joomla-cms that referenced this pull request May 26, 2019
change color of svg logos to 'atum-bg-dark'
hans2103 pushed a commit to hans2103/joomla-cms that referenced this pull request Nov 18, 2020
* Correct border-radius, add margin in list filter

* Make changes for filter more general
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants