-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion of "poster" attribute URL in SEF plugin #197
Conversation
Ryan, pelase create a joomalcode tracker and cross-reference here, |
The tracker already exists, I have posted a response to it - http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27711 |
Please separate issues. We are here dealing with the sef plugin only. |
Sorry I don't know how to separate the requests and I didn't realise Github would add them together. Should I close and re-open the pull request? |
@infograf768 you should be able to just apply this patch: https://github.com/ryandemmer/joomla-cms/commit/f811241c5432521c3979d0ba1a40c6ed34612ee5.diff @ryandemmer If you make a pull request based on a branch all new commits you push into that branch will be part of the pull request |
@ryandemmer |
This is fixed in JoomlaCode. Thanks for coding this, Ryan! :) Closing. |
change color of svg logos to 'atum-bg-dark'
* Correct border-radius, add margin in list filter * Make changes for filter more general
The SEF plugin does not convert the HTML5 poster attribute URL.
This commit adds the "poster" attribute to the regex alongside the "src and "href" attributes.
Tracker - http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27711