-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Replace "label" classes with the new "badge" ones #20328
Conversation
* [com_content] - archived legacy sef fix * cs
* Fix filter by multiple categories * Remove debug code
* Do not add unnecessary parameters in the archive link * Remove php notice * Unset parameter month=0 when year is not set
…19488) * move to protocol relative links to https * fix one broken font link
This reverts commit 05fd1d9.
Revert routing changes in 3.8.4
This reverts commit 0155f35.
This reverts commit 01a9147.
Revert content archive routing
@brianteeman @wilsonge may we merge this one, pretty please? |
@htmgarcia it can't be merged until it passes all the tests it still has zero user tests |
tests are reset when the code changes which you did when you resolved the conflicts |
There are 3 more in the screenshot that have to be replaced. |
@@ -29,7 +29,7 @@ | |||
<?php echo $option->label; ?> | |||
</td> | |||
<td> | |||
<span class="label label-<?php echo $option->state ? 'success' : 'important'; ?>"> | |||
<span class="badge badge-<?php echo $option->state ? 'success' : 'important'; ?>"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label-important
is now badge-danger
.
Sorry these should be the last ones.
|
I have tested this item ✅ successfully on 59ed416 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20328. |
Nice work! Thanks :) |
Pull Request for Issue # .
Summary of Changes
Replace "label" classes (not available in Bootstrap 4) with the new "badge" ones in frontend and backend
Testing Instructions
You can test in several places.
As example. Preview single articles that include tags in frontend
Expected result
The tags should have styling (color, background, etc) (with "badge" classes)
Actual result
The tags looks like regular links (with "label" classes)
Documentation Changes Required
Replacing the "label" classes with "badge" ones. That summarize this PR.