[mod_articles_category] Showon #20950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
reviewed
Jul 2, 2018
| @@ -52,7 +53,7 @@ MOD_ARTICLES_CATEGORY_FIELD_MODE_DESC="Please select the mode you would like to | |||
| MOD_ARTICLES_CATEGORY_FIELD_MODE_LABEL="Mode" | |||
| MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC="Please enter in a valid date format. See: http://php.net/date for formatting information." | |||
| MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_LABEL="Month and Year Display Format" | |||
| MOD_ARTICLES_CATEGORY_FIELD_RELATIVEDATE_DESC="If Relative Date is selected above, please enter in a numeric day value. Results will be retrieved relative to the current date and the value you enter." | |||
| MOD_ARTICLES_CATEGORY_FIELD_RELATIVEDATE_DESC="Please enter in a numeric day value. Results will be retrieved relative to the current date and the value you enter." | |||
There was a problem hiding this comment.
==> "Please enter a numeric value"
brianteeman
reviewed
Jul 2, 2018
| > | ||
| <option value="krsort">MOD_ARTICLES_CATEGORY_OPTION_DESCENDING_VALUE</option> | ||
| <option value="ksort">MOD_ARTICLES_CATEGORY_OPTION_ASCENDING_VALUE</option> | ||
| </field> | ||
|
|
||
| <field |
There was a problem hiding this comment.
Why is this field removed?
brianteeman
approved these changes
Jul 2, 2018
|
I have tested this item ✅ successfully on 35e8db5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20950. |
|
I have tested this item ✅ successfully on 35e8db5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20950. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20950. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This adds
showonattribute to form fields in Articles - Category module.Testing Instructions
Code review. Or create Articles - Category module and try different options. Check that fields are shown/hidden correctly.
Documentation Changes Required
Option from Dynamic Mode Options moved to Module tab. Update help page? https://docs.joomla.org/Help38:Extensions_Module_Manager_Articles_Category