[com_content] Redundant access check

[SharkyKZ]

Pull Request for Issue # .

Summary of Changes

This removes redundant access check from admin Articles model.

Testing Instructions

Code review. See that we already filter by access in the query:

joomla-cms/administrator/components/com_content/models/articles.php

Lines 250 to 256 in 88bcd98

	// Filter by access level on categories.
	if (!$user->authorise('core.admin'))
	{
	$groups = implode(',', $user->getAuthorisedViewLevels());
	$query->where('a.access IN (' . $groups . ')');
	$query->where('c.access IN (' . $groups . ')');
	}

Alternatively, you can check that this snippet (placed somehwere in frontend/site, e.g. in Protostar index file) doesn't return unauthorized articles. Where $accessLevel is some access level ID:

JModelLegacy::addIncludePath(JPATH_ADMINISTRATOR . '/components/com_content/models', 'ContentModel');
$model = JModelLegacy::getInstance('Articles', 'ContentModel', array('ignore_request' => true));
$model->setState('params',  JFactory::getApplication()->getParams());
$model->setState('filter.access', $accessLevel);
$articles = $model->getItems();
var_dump($articles);

Documentation Changes Required

No.

[bene-we]

I have tested this item ✅ successfully on 8d3d71e

What I tested:

On administrator site, create a new article with permission Super Users. After that I created a new user and added him to the administration group. I logged in with the newly created user and filtered for Super Users: No articles appear.

@icampus

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21169.}

[Tchangue]

I have tested this item ✅ successfully on 8d3d71e

I created two articles in the same menu: one with permission public and the other one with permission registered. By navigating on this menu we can only see the article with public access and when a user log in the second articles with permission registered appears.

@icampus

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21169.}

[ghost]

Ready to Commit after two successful tests.

[mbabker]

Since the extended method now does nothing useful, it can be removed too (no, there are no B/C issues with that).

[roland-d]

@SharkyKZ Can you update your PR as pointed out by @mbabker ?

[SharkyKZ]

Updated.

[roland-d]

@bene-we @Tchangue can you give this another test please?