Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CODE_OF_CONDUCT form the packages #21385

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Removing CODE_OF_CONDUCT form the packages #21385

merged 1 commit into from
Aug 3, 2018

Conversation

jeckodevelopment
Copy link
Member

Summary of Changes

This will remove CODE_OF_CONDUCT.md from the built packages as pointed out in #21383 (comment)

Expected result

CODE_OF_CONDUCT.md is not present in the packages.

Actual result

CODE_OF_CONDUCT.md is present in the packages after #21383 .

Documentation Changes Required

None

@jeckodevelopment
Copy link
Member Author

(don't ask me why GH asked automatically a review to all of you)

@jeckodevelopment jeckodevelopment changed the title Removing CODE_OF_CONDUCT Removing CODE_OF_CONDUCT form the packages Aug 3, 2018
@brianteeman
Copy link
Contributor

it is because they are the code owners for this file

@mbabker mbabker merged commit 2661b84 into joomla:staging Aug 3, 2018
@jeckodevelopment jeckodevelopment deleted the coc-nobuild branch August 3, 2018 11:56
@jeckodevelopment
Copy link
Member Author

Thanks for the explanation @brianteeman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants